Bug#416625: [PATCH] fix segfault in sink.c if fopen returns NULL

[Nico Golde]

Hi,
the attached patch fixes #416625 in Debian.
Kind regards
Nico

-- 
Nico Golde - http://www.ngolde.de
JAB: [EMAIL PROTECTED] - GPG: 0x73647CFF
Forget about that mouse with 3/4/5 buttons,
gimme a keyboard with 103/104/105 keys!

--- sink.c	2006-08-07 01:17:40.000000000 +0200
+++ sink_new.c	2007-03-29 14:49:54.000000000 +0200
@@ -699,6 +699,11 @@
     else
 	sinkfp = fopen(ctl->bsmtp, "a");
 
+    if (!sinkfp || ferror(sinkfp)) {
+        report(stderr, GT_("BSMTP file open or preamble write failed\n"));
+        return(PS_BSMTP);
+    }
+
     /* see the ap computation under the SMTP branch */
     need_anglebrs = (msg->return_path[0] != '<');
     fprintf(sinkfp,
@@ -738,12 +743,6 @@
 
     fputs("DATA\r\n", sinkfp);
 
-    if (ferror(sinkfp))
-    {
-	report(stderr, GT_("BSMTP file open or preamble write failed\n"));
-	return(PS_BSMTP);
-    }
-
     return(PS_SUCCESS);
 }
 

pgpbI3ftL3ZVz.pgp
Description: PGP signature