On Mon, Feb 12, 2007 at 02:43:17PM +0100, Patrik Weiskircher wrote:
> > 
> >> So in part it is my fault - I should have checked more carefully if it 
> >> gets installed. But I do not see any reason why the pppoeconf package 
> >> should not depend on the pppoe package - as far as I know you can't do 
> >> anything with pppoeconf without pppoe.
> > 
> > The only binary in pppoeconf is pppoe-discovery, which is part of
> > ppp package. Then there is no reason to have dependency with
> > pppoe package. I'm curious to see why you need another binary.
> 
> I think I know why it didn't work for me.
> I didn't have pppoe support in the kernel at first.. 

Do you use custom kernel ?
Because pppoe module is enabled in Debian kernels.

> Now I just looked into the pppoeconf script and discovered this:
> if test -x /usr/sbin/pppoe-discovery && test -e /proc/net/pppoe ; then
>   kernel_pppoe=1
>   DISCOVERY_PROGRAM=pppoe-discovery
> else
>   DISCOVERY_PROGRAM=pppoe
> fi
> export DISCOVERY_PROGRAM
> 
> As I didn't have /proc/net/pppoe it did a fallback to pppoe, which I didn't
> have installed either... as this error case is not checked it just.. did
> something undefined, I guess.
> 
> Maybe a better solution would be:
> if test -x /usr/sbin/pppoe-discovery && test -e /proc/net/pppoe ; then
>   kernel_pppoe=1
>   DISCOVERY_PROGRAM=pppoe-discovery
> else
>   if [ ! test -x /usr/bin/pppoe ]; then
>     echo "Please enable pppoe support in the kernel or install the pppoe"
>     echo "Package".
>     exit 1
>   fi
>   DISCOVERY_PROGRAM=pppoe
> fi
> export DISCOVERY_PROGRAM
> 
> Or something similar.

Thanks for your idea, I will revise that in next release
(FYI, not before Etch release).

Regards,
-- 
Gregory Colpart <[EMAIL PROTECTED]>  GnuPG:1024D/C1027A0E
Evolix - Informatique et Logiciels Libres http://www.evolix.fr/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to