Package: network-manager
Version: 0.6.4-6
Severity: normal
Tags: patch
While we were doing the regression test on one of our derivatives, we
found a problem that when we change the interface to have a static
address and then the network-admin application adds the 'auto' keyword
on the iface block, it broke the nm detection of device.
We produced a patch to solve it.
-- System Information:
Debian Release: 4.0
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-3-686
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8)
--- src/backends/NetworkManagerDebian.c 2007-01-19 13:36:15.000000000 -0200
+++ src/backends/NetworkManagerDebian.c 2007-01-19 13:39:27.000000000 -0200
@@ -552,8 +552,10 @@
*/
for (curr_b = ifparser_getfirst (); curr_b; curr_b = curr_b->next) {
if ((!strcmp (curr_b->type, "auto") || !strcmp (curr_b->type, "allow-hotplug"))
- && strstr (curr_b->name, iface))
- blacklist = FALSE;
+ && strstr (curr_b->name, iface)) {
+ blacklist = FALSE;
+ goto out;
+ }
}
/* If the interface has no options other than just "inet dhcp"
@@ -561,8 +563,10 @@
*/
for (curr_d = curr_device->info; curr_d; curr_d = curr_d->next) {
if (strcmp (curr_d->key, "inet")
- || strcmp (curr_d->data, "dhcp" ))
- blacklist = TRUE;
+ || strcmp (curr_d->data, "dhcp" )) {
+ blacklist = TRUE;
+ goto out;
+ }
}
out:
