Bug#407873: retchmail: -q option has no effect

[Joe Mason]

Package: retchmail
Version: 1:1.0-1
Severity: normal
Tags: patch

Using retchmail -qq I always see all headers printed, which makes it
hard to run from crontab.  The reason is that the dec_log_level callback
only updates a local copy of the log level variable.  Patch attached.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-2-686
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)

Versions of packages retchmail depends on:
ii  libc6                        2.3.6.ds1-9 GNU C Library: Shared libraries
ii  libuniconf4.2                4.2.2-2.2   C++ network libraries for rapid ap
ii  libwvstreams4.2-base         4.2.2-2.2   C++ network libraries for rapid ap
ii  libwvstreams4.2-extras       4.2.2-2.2   C++ network libraries for rapid ap
ii  libxplc0.3.13                0.3.13-1    Light weight component system

retchmail recommends no packages.

-- no debconf information

--- retchmail-1.0.orig/retchmail.cc
+++ retchmail-1.0/retchmail.cc
@@ -142,7 +142,7 @@
 
 static bool dec_log_level_cb(void *userdata)
 {
-    WvLog::LogLevel level = *static_cast<WvLog::LogLevel *>(userdata);
+    WvLog::LogLevel &level = *static_cast<WvLog::LogLevel *>(userdata);
     if ((int)level > (int)WvLog::Critical)
        level = (WvLog::LogLevel)((int)level - 1);
     return true;
@@ -151,7 +151,7 @@
 
 static bool inc_log_level_cb(void *userdata)
 {
-    WvLog::LogLevel level = *static_cast<WvLog::LogLevel *>(userdata);
+    WvLog::LogLevel &level = *static_cast<WvLog::LogLevel *>(userdata);
     if ((int)level < (int)WvLog::Debug5)
        level = (WvLog::LogLevel)((int)level + 1);
     return true;