Il giorno dom, 31/12/2006 alle 21.13 +0100, Paolo ha scritto:
[...]
> perhaps I'm mis-reading the script, but seems to me that lines 219..221
>
> $ invoke-rc.d hylafax stop
> $ (echo; echo no; echo no) | /usr/sbin/faxsetup -server
> $ invoke-rc.d hylafax start
>
> should be removed, at least the 'start' one, as next step @239 - ask the
> user if server should be (re)started - would be meaningless if
> RUN_HYLAFAX=1 already.
>
> I think both stop/start lines (219,221) should be removed; server should be
> (re)configured anyway, then ask user whether to actually (re)start it.
current code is a little different:
if invoke-rc.d hylafax stop
then
restart=true
else
restart=false
fi
(echo; echo no; echo no) | /usr/sbin/faxsetup -server
[ $restart == true ] && invoke-rc.d hylafax start
the meaning of this code is: we would like to startup hylafax only if it
was running during upgrade. And we need to have hylafax stopped while
running faxsetup. This stop/setup/start should be done regardless of the
way RUN_HYLAFAX is set, i.e., it should be done whenever hylafax is
automatically run at boot, or manually run at a later moment.
I agree on changing this code in order to restart hylafax only once. I
would do it this way:
if invoke-rc.d hylafax stop
then
restart=true
else
restart=false
fi
(echo; echo no; echo no) | /usr/sbin/faxsetup -server
# [ $restart == true ] && invoke-rc.d hylafax start
[...]
#
# ask the user if he want to start hylafax now and warn it about the
change in
# /etc/default/hylafax.
#
db_input low hylafax-server/start_now || true
db_go
db_get hylafax-server/start_now
if [ "$RET" = "true" ]; then
# removed redirect to /dev/null so that user knows that
# hylafax is actually restarting
sed -i -e 's/# RUN_HYLAFAX=1/RUN_HYLAFAX=1/'
/etc/default/hylafax
# invoke-rc.d hylafax stop || true
# Added || true in order to complete the installation even if
something goes
# wrong and the server is not starting
# Closes: #357435
invoke-rc.d hylafax start || true
elif [ $restart == true ]; then
invoke-rc.d hylafax start
fi
Do you think this would solve this bug?
Bye,
Giuseppe
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
