severity 403754 normal
merge 403754 391617
tags 391617 + patch
forwarded 403754 [EMAIL PROTECTED]
thanks
heya again,
On Tue, Dec 19, 2006 at 07:25:28PM +0100, Romain Beauxis wrote:
> Le mardi 19 décembre 2006 17:39, Michael Ablassmeier a écrit :
> > hi,
>
> Hi !
>
> > hm, well, imho the manpage says it clearly:
> >
> > [..]
> > Also, the submit method requires that the following configuration
> > parameters be set for this "Audio::Scrobbler" object:
> >
> > * username
> > The username of the user's AudioScrobbler registration.
> >
> > * password
> > The password for the AudioScrobbler registration.
>
> That's precisly what I was talking about, when I was testing the perl module,
> submit failed when password was passed only at submit function, I had to pass
> it at the constructor too. In the helper example, it seems that the
> paramaters passed to the constructor and submit are the same...
hmkey, this patch should make it work either way:
--- Scrobbler.pm 2006-12-19 19:34:26.000000000 +0100
+++ /usr/share/perl5/Audio/Scrobbler.pm 2006-12-19 19:35:34.000000000 +0100
@@ -279,7 +279,7 @@
$t[5] + 1900, $t[4] + 1, @t[3, 2, 1, 0]);
# Let's hope md5_hex() always returns lowercase hex stuff
$md5resp = md5_hex(
- md5_hex($self->{'cfg'}{'password'}).$self->{'md5ch'});
+ md5_hex($self->{'cfg'}{'password'} ? $self->{'cfg'}{'password'} :
$info->{'password'}).$self->{'md5ch'});
# Let's roll?
$req = HTTP::Request->new('POST', $self->{'nexturl'});
> > the package ships /usr/bin/scrobbler-helper, you might want to have a
> > look at this one. Example config is shipped aswell. Im going to add a
> > pointer to this script in README.Debian.
>
> Yes, but this script is very difficult to understand since the option array
> is
> never explicitly stated. For instance I had to go through the specs online to
> guess a correct progname and progversion (mandatory)..
>
> Here is a simple example that works for for me (c):
im going to add a sample script. Lets give upstream some days to sort out those
issues first, if this doesnt happen in a foreseable time im going to add
patches.
bye,
- michael
