On Tue, 2006-12-05 at 09:59 +0200, Fabian Fagerholm wrote:
> Thanks for the report Michele, I'm marking this as found and I'm
> starting to investigate. (I was able to reproduce the bug as you
> showed.)

Apparently the input string can be terminated by just a single LF. I
presume that in some circumstances, it could be terminated by a single
CR, as well.

The attached patch covers these cases.

Note that the actual base64 decoding works just fine. These errors arise
because sasl_decode64 assumes that the input data is strictly and only
the base64-encoded data, without any line terminators, while client
programs expect line terminators to be silently ignored.

A more "correct" fix would be to have all client programs strip off line
terminators before calling sasl_decode64, but that's just not
practically possible to achieve right now.

-- 
Fabian Fagerholm <[EMAIL PROTECTED]>

Attachment: 0015_saslutil_decode64_fix.dpatch
Description: application/shellscript

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to