Hi

On Wed, Nov 22, 2006 at 11:47:54AM +0100, Marc Haber wrote:
> On Wed, Nov 22, 2006 at 11:30:47AM +0100, Ola Lundqvist wrote:
> > On Wed, Nov 22, 2006 at 10:13:36AM +0100, Marc Haber wrote:
> > > on systems with a long sources.list, servers unreachable and cron-apt
> > > being invoked often, it is possible that a new cron-apt is started
> > You really use cron-apt heavily. ;)
> 
> Yes, on all my systems.
> 
> > > At this time, $TMPDIR/initlog was already created, but onexit()
> > > doesn't zap $TMPDIR/initlog, and thus the rmdir $TMPDIR in onexit()
> > > fails ("Directory not empty"). This error message is delivered by cron
> > > in an extra mail message.
> > 
> > But in this case it should not zap this file?
> 
> Why shouldn't it?

Doh! I read $TMP instead of $TMPDIR. :)

> > And in that case what should happen is thta the rmdir operation
> > should not display a problem if it is not empty.
> > 
> > Something like this instead.
> > rmdir xxx > /dev/null 2>&1
> > 
> > Is that a sufficient solution for you?
> 
> That would leave a temp directory _and_ a temp file around for each
> invocation. This night alone (where ftp2.d.o was down for the better
> part of the night) this amounted to like 200 inodes.

Not good.

> I would prefer cron-apt properly cleaning up. Probably, the contents
> of initlog could be prepended to the "cannot acquire cron-apt lock"
> message.

I fully agree.

Can you arrange a patch (that you test) or do you want me to correct this
problem?

Regards,

// Ola

> Greetings
> Marc
> 
> -- 
> -----------------------------------------------------------------------------
> Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
> Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
> Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835
> 
> 

-- 
 --------------------- Ola Lundqvist ---------------------------
/  [EMAIL PROTECTED]                     Annebergsslingan 37      \
|  [EMAIL PROTECTED]                 654 65 KARLSTAD          |
|  +46 (0)54-10 14 30                  +46 (0)70-332 1551       |
|  http://www.opal.dhs.org             UIN/icq: 4912500         |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36  4FE4 18A1 B1CF 0FE5 3DD9 /
 ---------------------------------------------------------------


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to