On Mon, Oct 16, 2006 at 10:41:25AM +0200, Martin Pitt wrote:
> Daniel Kobras [2006-08-18 19:02 +0200]:
> > --- imagemagick-6.2.4.5.dfsg1.orig/coders/sgi.c
> > +++ imagemagick-6.2.4.5.dfsg1/coders/sgi.c
> > @@ -171,13 +171,13 @@
> >    q=pixels;
> >    if (bytes_per_pixel == 2)
> >      {
> > -      for (i=0; i < (long) width; )
> > +      for ( ; ; )
> >        {
> >          pixel=(unsigned long) (*p++) << 8;
> >          pixel|=(*p++);
> >          count=(ssize_t) (pixel & 0x7f);
> >          i+=count;
> 
> BTW, this hunk looks wrong: You removed the initialization 'i=0'
> without adding a replacement. I'm not intimately familiar with the C
> specification, is a 'register long i' guaranteed to be initialized to
> 0? It would surprise me if that was true. For being on the safe side,
> the 'i=0' should be put back.

D'oh! You're right, of course. I'll prepare an update.

Thanks,

Daniel.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to