On Wed, Oct 11, 2006 at 01:08:44PM +0200, DaVinci wrote:
> El miércoles 11 de octubre, Elimar Riesebieter escribió:
> > On Wed, 11 Oct 2006 the mental interface of
> > DaVinci told:
> >
> > [...]
> > > I have not tryed. I'll see it playing a gigantic list. But I want to
> > > know: do you all experience a constant used memory increment when
> > > running moc?
> >
> > Running mocp for more than 1 hour with a playlist of about 400 titles:
> >
> > PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
> > 7127 riesebie 15 0 75560 7936 3144 S 2.0 1.0 1:21.74 mocp
>
> Great test. Now I have found something new. If I use moc with mp3 or
> wav files, memory use is stable, like yours, but when I play flac files
> the problem with raising memory use appears.
>
> Perhaps a question of interfacing with flac library?
I've discovered a memory leak in the code that read tags for FLAC files.
I don't really belive that this could cause such big memory consumption,
but you can try the attached patch.
--
Damian Pietras
Index: decoder_plugins/flac/flac.c
===================================================================
--- decoder_plugins/flac/flac.c (revision 1931)
+++ decoder_plugins/flac/flac.c (working copy)
@@ -356,6 +356,8 @@
}
else
free (value);
+
+ free (name);
}
static void get_vorbiscomments (const char *filename, struct file_tags *tags)
