Package: qemu
Version: 0.8.1-1
Severity: normal
Tags: patch
Hi,
Somethings seems odd in 0.8.1-1's ne2000_can_receive():
static int ne2000_can_receive(void *opaque)
{
NE2000State *s = opaque;
if (s->cmd & E8390_STOP)
return 1;
return !ne2000_buffer_full(s);
}
If the command is STOP, shouldn't can_receive rather return 0?! (just
like it did in version 0.8.0-3). Here is a patch.
Samuel
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (900, 'testing'), (500, 'unstable'), (500, 'stable'), (1,
'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-rc5
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15)
Versions of packages qemu depends on:
ii bochsbios 2.2.6-2 BIOS for the Bochs emulator
ii libasound2 1.0.11-7 ALSA library
ii libc6 2.3.6.ds1-4 GNU C Library: Shared libraries
ii libsdl1.2debian 1.2.11-3 Simple DirectMedia Layer
ii openhackware 0.4.1-2 OpenFirmware emulator for PowerPC
ii proll 18-2 JavaStation PROM 2.x compatible re
ii vgabios 0.6a-1 VGA BIOS software for the Bochs an
ii zlib1g 1:1.2.3-13 compression library - runtime
Versions of packages qemu recommends:
ii debootstrap 0.3.3 Bootstrap a basic Debian system
ii sharutils 1:4.2.1-15 shar, unshar, uuencode, uudecode
-- no debconf information
--- qemu-0.8.1-orig/hw/ne2000.c 2006-05-03 22:32:58.000000000 +0200
+++ qemu-0.8.1/hw/ne2000.c 2006-09-06 01:28:39.000000000 +0200
@@ -220,7 +220,7 @@ static int ne2000_can_receive(void *opaq
NE2000State *s = opaque;
if (s->cmd & E8390_STOP)
- return 1;
+ return 0;
return !ne2000_buffer_full(s);
}
