forwarded 298796 https://bugzilla.mozilla.org/show_bug.cgi?id=285613
tag 298796 + patch
thanks
On Thu, Mar 10, 2005 at 07:32:05PM +0200, Cesar Martinez Izquierdo <[EMAIL
PROTECTED]> wrote:
> El Jueves 10 Marzo 2005 19:22 escribiste:
> > It's actually clearer when you look at the formal definitions:
> >
> > document ::= prolog element Misc* [1]
> > prolog ::= XMLDecl? Misc* (doctypedecl Misc*)? [2]
> > XMLDecl ::= '<?xml' VersionInfo EncodingDecl? SDDecl? S? '?>' [3]
> > Misc ::= Comment | PI | S [4]
> > S ::= (#x20 | #x9 | #xD | #xA)+ [5]
>
> Yes, it seems quite clear here, thanks.
>
> BTW, here there is the bug at mozilla.org:
>
> https://bugzilla.mozilla.org/show_bug.cgi?id=285605
That's the malformed XML bug. Here is the bug I filed about the E.M.
crash issue :
https://bugzilla.mozilla.org/show_bug.cgi?id=285613
Attached is a not very nice, but effective fix.
Cheers
Mike
diff -u
mozilla-firefox-1.0.1/toolkit/mozapps/extensions/src/nsExtensionManager.js.in
mozilla-firefox-1.0.1/toolkit/mozapps/extensions/src/nsExtensionManager.js.in
---
mozilla-firefox-1.0.1/toolkit/mozapps/extensions/src/nsExtensionManager.js.in
+++
mozilla-firefox-1.0.1/toolkit/mozapps/extensions/src/nsExtensionManager.js.in
@@ -2021,7 +2021,12 @@
ensurePreConfiguredItem: function nsExtensionManager_ensurePreConfiguredItem
(aItemID, aItemType, aManifest)
{
this._ds.insertForthcomingItem(aItemID, aItemType, false);
- var metadataDS = getInstallManifest(aManifest);
+ try {
+ var metadataDS = getInstallManifest(aManifest);
+ }
+ catch (e) {
+ return;
+ }
this._ds.addItemMetadata(aItemID, aItemType, metadataDS, false);
// Check whether the extension is installable (firefox_version fitting
between
diff -u mozilla-firefox-1.0.1/debian/changelog
mozilla-firefox-1.0.1/debian/changelog
--- mozilla-firefox-1.0.1/debian/changelog
+++ mozilla-firefox-1.0.1/debian/changelog
@@ -1,3 +1,10 @@
+mozilla-firefox (1.0.1-3) unstable; urgency=low
+
+ * toolkit/mozapps/extensions/src/nsExtensionManager.js.in: avoid crashing
+ when extension's install.rdf is broken. (Closes: #298796)
+
+ -- Mike Hommey <[EMAIL PROTECTED]> Thu, 10 Mar 2005 14:24:55 +0100
+
mozilla-firefox (1.0.1-2) unstable; urgency=high
* Changes by Mike Hommey:
