Package: dbconfig-common
Version: 1.8.17
Severity: wishlist
Tags: patch
Hello,
The generated include for file type PHP ends in '?>'. I kindly request
that that be removed.
The problem is that everything after that tag will be output to the
browser, and that can cause trouble if there's e.g. some stray
whitespace after it, which can mess up the sending of headers or the
integrity of binary files sent with PHP.
The closing tag is not needed and doesn't have a function: you switch
the context from code to literal and right after it terminate the file,
making the context irrelevant.
Please consider to apply this patch. Thanks.
Thijs
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.11-1-k7
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages dbconfig-common depends on:
ii debconf [debconf-2.0] 1.5.2 Debian configuration management sy
ii pwgen 2.05-1 Automatic Password generation
ii ucf 2.0012 Update Configuration File: preserv
dbconfig-common recommends no packages.
-- debconf information excluded
diff -ur dbconfig-common-1.8.17.orig/dbconfig-generate-include
dbconfig-common-1.8.17/dbconfig-generate-include
--- dbconfig-common-1.8.17.orig/dbconfig-generate-include 2006-04-23
18:58:48.000000000 +0200
+++ dbconfig-common-1.8.17/dbconfig-generate-include 2006-07-26
18:38:38.000000000 +0200
@@ -266,7 +266,6 @@
[ "$use_dbport" ] && echo
"${comment_dbport}\$$dbport_varname='$dbc_dbport';"
[ "$use_dbtype" ] && echo
"${comment_dbtype}\$$dbtype_varname='$dbc_dbtype';"
cat << EOF
-?>
EOF
;;
diff -ur dbconfig-common-1.8.17.orig/dbconfig-load-include
dbconfig-common-1.8.17/dbconfig-load-include
--- dbconfig-common-1.8.17.orig/dbconfig-load-include 2006-04-02
17:26:06.000000000 +0200
+++ dbconfig-common-1.8.17/dbconfig-load-include 2006-07-26
18:38:49.000000000 +0200
@@ -196,7 +196,6 @@
echo "dbc_dbport='\$$dbport_varname';\n";
if(!empty(\$use_dbtype) && isset(\$$dbtype_varname))
echo "dbc_dbtype='\$$dbtype_varname';\n";
-?>
EOF
;;
