Control: tags -1 patch
On Thu, 14 May 2026 01:24:41 +0200 Gioele Barabucci <[email protected]>
wrote:
it appears that acpi-support uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of acpi-support
that use `pidof` at runtime;
* via the `Build-Depends:` field of acpi-support, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of acpi-support, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that acpi-support uses `pidof` due to the following
code snippets:
```
path: acpi-support_0.143-5.2/debian/addons/lib/screenblank
fi
if [ x$LOCK_SCREEN = xtrue ]; then
if pidof xscreensaver >/dev/null; then
su "$XUSER" -s /bin/sh -c "xscreensaver-command -lock"
elif pidof gnome-screensaver > /dev/null; then
[...]
Dear acpi-support maintainer,
`acpi-support-base` ships `/usr/share/acpi-support/policy-funcs` that
calls `pidof` in `CheckUPowerPolicy()`, so that it must have a hard
dependency on `procps`.
Transitively, making `acpi-support-base` depend on `procps` will make
also the full package `acpi-support` depend on it, covering all usages
of `pidof` found in various addon scripts.
A MR with a fix for this issue can be found at:
<https://salsa.debian.org/debian/acpi-support/-/merge_requests/3>.
Regards,
--
Gioele Barabucci
