The Debian NEW review of rust-derivre 0.3.12-3 has been completed.

Decision: ACCEPTED
Reviewer: Andrew McMillan

Review comment:

Hi,

Some packaging-quality issues.  I suspect you already know these though...

Major downgrade of hashbrown (0.17.1 → 0.14.5).

Cargo.toml.orig:20 requires 0.17.1, but debian/patches/relax-version.patch 
rewrites it to 0.14.5 (two major versions older) purely because Debian only has 
0.14 (control:18,37). The crate uses hashbrown::hash_table::Entry/HashTable 
(src/hashcons.rs:1,4), which still exist in 0.14 so it compiles, but this 
silently changes the hash-table implementation upstream pinned — worth flagging 
for review rather than accepting blindly.

Test-only dev-dependencies missing from Build-Depends-Arch.

The crate's test targets (tests/basic.rs, fowler.rs, etc.) depend on bstr, 
serde, toml (Cargo.toml:86-99), but none of these appear in control 
Build-Depends. They're only listed in debian/tests/control for autopkgtest. 
Since debian/rules is a plain dh $@ --buildsystem cargo with no nocheck, the 
build-time test run cannot build these targets — a likely FTBFS unless tests 
are intentionally skipped. (Worth verifying against CI.)


Thanks!

Full review details: https://dfsg-new-queue.debian.org/reviews/rust-derivre

Reply via email to