On Sun, Aug 16, 2026 at 11:19 AM Ben Hutchings <[email protected]> wrote:
>
> From: Matteo Croce <[email protected]>
>
> The log level for short  messages was changed from debug to warning,
> flooding syslog on systems with devices that regularly send
> short reports, in my case an UPS:
>
>     $ dmesg |grep -c 'Event data for report .* was too short'
>     35
>
> Demote it back to debug level.
>
> Fixes: 0a3fe972a7cb ("HID: core: Mitigate potential OOB by removing bogus 
> memset()")
> Signed-off-by: Matteo Croce <[email protected]>
> [bwh: Re-sending this fix which was applied and then lost in a mis-
>  merge.  Add a second Fixes trailer so this should reach all stable
>  branches that have the warning.]
> Fixes: 2c85c61d1332 ("HID: pass the buffer size to hid_report_raw_event")
> Cc: [email protected]
> Signed-off-by: Ben Hutchings <[email protected]>
> ---
> This was originally posted at
> <https://lore.kernel.org/linux-input/[email protected]/>
> and applied to the hid tree as commit d0ff08d946c8, but then it was
> lost in merge commit aa776949fb77 "Merge branch 'for-7.2/wiimote' into
> for-linus".

Sorry, but, NACK.

See the discussion with Lee ATM on the LKML[0]

That intermediate "fix" was wrong and got merged while I was working
on a proper solution, which is now upstream.

Cheers,
Benjamin

[0] https://lore.kernel.org/linux-input/aoxcpDR8jnuUA1nF@beelink/T/#t

>
> Ben.
>
>  drivers/hid/hid-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index cf123347a2af..605530ec2e9c 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -2079,8 +2079,8 @@ int hid_report_raw_event(struct hid_device *hid, enum 
> hid_report_type type, u8 *
>                 rsize = max_buffer_size;
>
>         if (bsize < rsize) {
> -               hid_warn_ratelimited(hid, "Event data for report %d was too 
> short (%d vs %zu)\n",
> -                                    report->id, rsize, bsize);
> +               hid_dbg_ratelimited(hid, "Event data for report %d was too 
> short (%d vs %zu)\n",
> +                                   report->id, rsize, bsize);
>                 return -EINVAL;
>         }
>

Reply via email to