On Wed, Jul 29, 2026 at 09:37:14AM +0200, David Kalnischkies wrote:
Am Tue, Jul 28, 2026 at 07:18:44AM -0400, schrieb James McCoy:
I haven't had time yet to try and bisect which patch changed the
behavior.
The test is the same as another one that works just fine except
that it inoremap's <C-n> to <Down>. The test triggers the
completion popup (that offers the choices c, x & a as they are
member variables of the foo struct, but whatever) by writing '.'.
Pressing "next" in the form of <Tab>, <Down> or even default <C-n>
selects the first/next item in the completion choice and crucially
writes the choice to the line as well.
Thanks for the repro script. That was very helpful.
The problematic commit is
commit 076585e6addb5688f123ef3e174fcfee993b7602 (tag: v9.2.0624)
Author: Thomas M Kehrenberg <[email protected]>
Date: Sat Jun 13 14:36:58 2026 +0000
patch 9.2.0624: C-N/C-P cannot be mapped in complete() completion
Problem: Keys valid in CTRL-X mode are never mapped while insert
completion is active, so <C-N> and <C-P> cannot be remapped
for completion started by complete().
Solution: Do not disable mappings in CTRL_X_EVAL mode. In this mode a
mapping cannot interfere with selecting the completion
method, which is what the no-mapping rule exists for.
related: #6440
related: #16880
closes: #20489
So, this is an intentional relaxing of behavior to allow remapping. I
think skipping the tests is correct, since the behavior being tested has
changed.
Cheers,
--
James (he/him)
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
