Hi!
Steve Langasek wrote:
> As mentioned earlier this month, a regression was found in the freetype
> 2.1.7-2.5 package uploaded for DSA-1095 which caused applications to crash
> with division-by-zero errors. I've prepared a maintainer upload to fix
> this regression using the patch from bug #373581, which can be found at
> <http://people.debian.org/~vorlon/freetype-DSA/>.
Are you sure this is the proper fix?
-+ if ((FT_ULong)pitch > LONG_MAX/height)
++ if (height != 0 && (FT_ULong)pitch > LONG_MAX/height)
I'd rather make it read:
if (height <= 0 || (FT_ULong)pitch > LONG_MAX/height)
because later we have "pitch * height" which will result in a malloc
of zero.
That way, OOo won't crash anymore but may handle the font error
properly.
The package contains changes to debootstrap.log that should
not be there btw.
Regards,
Joey
--
Reading is a lost art nowadays. -- Michael Weber
Please always Cc to me when replying to me on the lists.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
