On Tue, 31 Mar 2026 12:56:05 +0200 Agustin Martin <[email protected]> wrote:
> On Tue, Mar 31, 2026 at 04:04:04PM +0800, Chow Loong Jin wrote:
> > On Mon, Mar 30, 2026 at 01:05:34AM +0200, Agustin Martin wrote:
> > > On Thu, Sep 18, 2025 at 11:58:56AM +0800, Chow Loong Jin wrote:
> > > > Package: devscripts
> > > > Version: 2.25.19ubuntu2
> > > > Severity: normal
> > > > When using the following debian/watch file:
> > > >
> > > > --- debian/watch --
> > > > Version: 5
> > > >
> > > > Template: Github
> > > > Owner: prusa3d
> > > > Project: prusaslicer
> > > > Release-Only: yes
> > > > ---
> > > ...
> > > > This is wrong, because according to
> > > > https://docs.github.com/en/rest/git/refs?apiVersion=2022-11-28, this
> > > > actually means it's trying to search for git refs matching
> > > > `refs/release/*`, which don't exist.
> > > >
> > > > Instead, the URL to search should be
> > > > https://api.github.com/repos/prusa3d/prusaslicer/releases, which
> > > > actually lists the releases for the project, along with tarball links.
> > >
> > > Hi all,
> > >
> > > Seems that attached patch helps with the 'Release-Only' problem in 
> > > rdma-core
> > > and nextcloud-desktop, using pure template watch files.
> > >
> > > It however does not help with slic3r-prusa because of the "version_" 
> > > prefix.
> >
> > I think downloadurlmangle should not be set when release-only is true.
> > It might be better to separate the logic for releaseonly into completely
> > different if-else branches instead of using a ternary.
>
> Hello,
>
> Agreed in the general case. Same for matchingpattern (See #1120369 uscan:
> Github template w/ custom Matching-Pattern fails: Unknown compression).
> While there may be some uses where this can be done safely, seems that this
> is not true in the general case.
>
> I have seen that Yadd has opened a merge request to use a new
> 'Version-Prefix' option,
>
> https://salsa.debian.org/debian/devscripts/-/merge_requests/633
>
> Did not test it yet. Will not be able to write comments to salsa for some
> days, but hope to test that change soon.
>
> In parallel I have thinking about a new 'Custom-Version' option for more of
> less "special" versioning. See attached patch. With it and an entry like
>
> Custom-Version: version_@ANY_VERSION@
>
> in slic3r-prusa debian/watch, seems that things are working.
>
> Changes in Github.pm in this patch may be needed regardless of this 
> particular problem.

> Note that it is a very first cut and is tested only with slic3r-prusa. It 
> should only be used with templates.
>
> > Additionally, it would be nice to have a new setting to select only
> > asset tarballs instead of snapshot tarballs. For example, in hyprland,
> > with the following watch file, we would like to use [1] instead of [2],
> > because the latter lacks hardcoded version info (see [3] for a diff) and
> > leads to bugs like [4].

> I like the https://github.com address and I would like to have a reference
> to [2] in the releases page. Otherwise the possible problem is that if
> github changes location template would need change.

Sorry, I meant [1]

By the way, I tested my last #1115546 patch (together with the
previous one) with #1120369. Instead of trying to use Matching-Pattern
I used my proposed new 'Custom-Version' option with something like

Custom-Version: v(0\.7\.\d+)

in 1120369 to restrict to a particular set of versions. Seems to work.

-- 
Agustin

Reply via email to