> Lintian checks whether the package build depends on libtool or
> dh-autoreconf, but this is no longer needed as dh depends on
> dh-autoreconf now.
And with respect to this part of the bug report, it appears to me that something
in the check ought to be changed.
Debhelper depends on dh-autoreconf and dh-autoreconf depends on libtool.
So as such both the checks are redundant.
The check in question that we talk about it is:
| $self->pointed_hint('ancient-libtool', $item->pointer)
| if $item->basename eq 'ltconfig'
| && $item->name !~ m{^ debian/ }sx
| && !$self->libtool_in_build_depends;
`libtool_in_build_depends` checks for "dh-autoreconf | libtool".
It seems that when the check was added, it was added with the assumption that
build depending on either of the two would mean that the maintainer is going
to run them in d/rules and hence this tag was not
triggered if a B-D on dh-autoreconf or libtool was found.
However, with debhelper depending on these now, we can think of modifying checks
in 2 ways:
1. Assume that if a package build depends on debhelper it will always run
autoreconf
and we will not have the ancient libtool issue ever. This does not work when
packages
start to override dh_autoreconf and do not run dh_autoreconf again. I can see
some
packages doing that [1] but not many in number. This would fix the problem for
the
package in question (gcc-h8300-hms) as well.
2. Drop the check on `libtool_in_build_depends` altogether and just assume that
whenever
we see these files it is going to be a problem. But this would mean that FPs
will be
triggered.
Both of them appear not optimal to me. @pollo again, any opinions?
[1]
https://codesearch.debian.net/search?q=override_dh_autoreconf+path%3Adebian%2Frules&literal=1&page=13
Thanks
Nilesh
