Bug#1126442: reportbug does not handle HTTP-error 503 appropriately

[Georges Khaznadar]

Hello,

the reason of the bug is that the error message contains "<" and ">" characters
which must be encoded as HTML entities before feeding the user interface.

Please find the attached patch, which fixes this issue.

Best regards,                   Georges.

bh_...@mailbox.org a écrit :
> When I run reportbug from terminal and retrieval of current bug-reports 
> starts,
> I receive
> 
> % reportbug
> 
> (reportbug:579150): Gtk-WARNING **: 09:14:23.929: Failed to set text 'Error
> retrieving information on existing bug reports from the BTS. The following
> error was detected:
> Unable to connect to Debian BTS (error: "<HTTPError 503: 'All backends failed
> or unhealthy'>");
> Do you still want to file a report?' from markup due to error parsing markup:
> Error on line 2 char 59: “503:” is not a valid name

diff --git a/reportbug/ui/gtk_ui.py b/reportbug/ui/gtk_ui.py
index 15fd7be..debdfff 100644
--- a/reportbug/ui/gtk_ui.py
+++ b/reportbug/ui/gtk_ui.py
@@ -1761,7 +1761,7 @@ class YesNoDialog(ReportbugConnector, Gtk.MessageDialog):
 
     def execute_operation(self, msg, yeshelp=None, nohelp=None, default=True, nowrap=False):
         _assert_context(ui_context)
-        self.set_markup(msg)
+        self.set_markup(msg.replace("<","&lt;").replace(">","&gt;"))
         if default:
             self.set_default_response(Gtk.ResponseType.YES)
         else:

signature.asc
Description: PGP signature