Control: severity -1 normal
Control: retitle -1 kwstyle/1.1.0~git20250114.eb1e46d+ds-1 [ITA] -- Style 
checker for source code
Control: tags -1 moreinfo

Hi 何庆 Ching He,

(changing severity, as I  think there is no RC bug to be fixed)

d/changelog
- comparing your source package to the archive (currently at 
1.1.0~git20200506.b253a2b-1.1)
shows differences, e.g the never uploaded package version 
1.1.0~git20211008.1173206+ds-1
Please make sure not to "rewrite history", so please drop the entries never 
uploaded.
If you change an older entry, like the "trailing space" difference I see
in an entry for 1.1.0~git20200506.b253a2b-1, this needs a changelog
entry.
- you repeating changelog entries from the NMU, and closing #1113091
  again. Any reason for that? If the fix for #1113091 was incomplete,
  for example, this needs to clear from the changelog entry, the bug
  needs to be reopened and ammended.
  (As the buildds are happy, I think the changelog entry is wrong, and
  the bug is not re-fixed, so please feel free to correct my
  understanding or drop the line in the changelog.
- d/changelog says S-V is being bumped to 4.7.0 - but we are at 4.7.3 already,
  according to d/control, I guess this is a typo.
- you are starting to repack (+ds), but that is not documented. (the
  changelog should tell why are you repacking?)

d/copyright has dropped a paragraph, not documented in d/changelog:
  Accidentially dropped or not documented?

Cheers,
tobi

Reply via email to