This one time, at band camp, Martin Stolle said: > It would be nice, if dvdbackup would not immediately abort on a read > error (maybe scratches), but instead pads the missing blocks and reads > on. I have attached a patch that does it and it would be nice if it > could be included by default. It adds a new command line swtich -r > which specifies how to handle read errors. -r a means abort (current > behavior). -r b means skip single block. -r m means skip multiple > blocks (as many as were left in the failed read-request, up to 1MB). > The last option is necessary for some drives whose firmware locks up > if one tries to read oen block after the after which are scratched.
Thank you for the patch. I will review it this weekend, when I have a little more time to go slowly and carefully. At first glance it looks like the correct way to do what you want with dvdbackup. I do feel a little like the best place for this sort of work is in libdvdread, though, with just the policy layer in the front end. I am not sure how trivial it would be to patch libdvdread to just return null blocks on read failure, however. That being said, I am not opposed to applying the patch - I just wanted to mention that there might be cleaner ways to do this sort of thing, that would also allow all other libdvdread using applications to benefit. Take care, -- ----------------------------------------------------------------- | ,''`. Stephen Gran | | : :' : [EMAIL PROTECTED] | | `. `' Debian user, admin, and developer | | `- http://www.debian.org | -----------------------------------------------------------------
signature.asc
Description: Digital signature
