Package: xmms-singit
Severity: normal
Tags: patch
When building 'xmms-singit' on amd64 with gcc-4.0,
I get the following error:
x86_64-linux-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -I./dialogs -I./editor
-I./include -I./sound -I./tagger -I./widgets -I.. -I.. -I/usr/include/libxml2
-DLOCALE_DIR=\"/usr/share/xmms/SingIt/locale\"
-DPLUGIN_DIR=\"/usr/lib/xmms/Visualization\" -O2 -D_REENTRANT -g -Wall
-Wpointer-arith -finline-functions -ffast-math -funroll-all-loops
-I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include
-D_REENTRANT -I/usr/include/xmms -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2
-I/usr/lib/glib/include -MT singit_song.lo -MD -MP -MF .deps/singit_song.Tpo -c
singit_song.c -fPIC -DPIC -o .libs/singit_song.o
singit_song.c: In function 'singit_song_new':
singit_song.c:150: error: invalid lvalue in assignment
singit_song.c: In function 'singit_song_get_id3_tag':
singit_song.c:367: error: invalid lvalue in assignment
singit_song.c: In function 'singit_song_extract_token':
singit_song.c:661: warning: pointer targets in passing argument 2 of
'extrakt_timetag_information' differ in signedness
singit_song.c: In function 'singit_song_remove_token':
singit_song.c:692: warning: pointer targets in passing argument 2 of
'extrakt_timetag_information' differ in signedness
make[4]: *** [singit_song.lo] Error 1
make[4]: Leaving directory `/xmms-singit-0.1.28/src'
With the attached patch 'xmms-singit' can be compiled
on amd64 using gcc-4.0.
Regards
Andreas Jochens
diff -urN ../tmp-orig/xmms-singit-0.1.28/src/singit_song.c ./src/singit_song.c
--- ../tmp-orig/xmms-singit-0.1.28/src/singit_song.c 2003-07-16
14:30:57.000000000 +0200
+++ ./src/singit_song.c 2005-03-03 13:13:52.072116699 +0100
@@ -147,7 +147,7 @@
else {
ssong->song_filename = song_filename;
#ifdef HAVE_ID3
- TAG(ssong) = NULL;
+ ssong->id3tag = NULL;
#endif
}
return GTK_OBJECT(ssong);
@@ -364,7 +364,7 @@
inline void singit_song_get_id3_tag(SingitSong *ssong, gchar *filename)
{
#ifdef HAVE_ID3
- if (!TAG(ssong)) { TAG(ssong) = ID3Tag_New(); }
+ if (!ssong->id3tag) { ssong->id3tag = ID3Tag_New(); }
else { ID3Tag_Clear(TAG(ssong)); }
if (TAG(ssong)) { ID3Tag_Link_WRP(TAG(ssong), filename); }
#endif
diff -urN ../tmp-orig/xmms-singit-0.1.28/src/singit_song_id3v2xx.c
./src/singit_song_id3v2xx.c
--- ../tmp-orig/xmms-singit-0.1.28/src/singit_song_id3v2xx.c 2003-05-30
13:11:00.000000000 +0200
+++ ./src/singit_song_id3v2xx.c 2005-03-03 13:40:52.699305750 +0100
@@ -54,7 +54,7 @@
}
if (TAG(my_song) == NULL) {
- TAG(my_song) = ID3Tag_New();
+ my_song->id3tag = ID3Tag_New();
ID3Tag_Link_WRP(TAG(my_song), (*filename));
}
@@ -93,7 +93,7 @@
}
if (TAG(my_song) == NULL)
- { TAG(my_song) = ID3Tag_New(); }
+ { my_song->id3tag = ID3Tag_New(); }
ID3Tag_Link_WRP(TAG(my_song), filename);
if (ID3Tag_NumFrames(TAG(my_song)) <= 0) {
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
