Bug#1104851: RFS: devilutionx/1.5.4+ds2-1 [ITP] -- diablo build for modern operating systems

Kirill Rekhov Thu, 28 Aug 2025 05:29:26 -0700

Hi, Antoine

I’ve made the fixes you pointed out.


Could you add me to the games-team so I can create
https://salsa.debian.org/games-team/devilutionx and push the new changes?
--
Regards, Kirill Rekhov

Currently Debian Maintainer
GPG Fingerprint: 2640 769D FDA1 AAA0 F863  D1AE 5F2C 5905 519C E0A0

Debian Salsa: https://salsa.debian.org/krekhov
Debian Person: https://nm.debian.org/person/krekhov
Debian QA Page:
https://qa.debian.org/[email protected]

GitHub: https://github.com/krekhovx


сб, 23 авг. 2025 г. в 16:11, Antoine Le Gonidec <[email protected]>:

> Le Sat, Aug 23, 2025 at 12:28:40PM +0300, Kirill Rekhov a écrit :
> > Sorry for the late reply, yes if you want you can view/upload this
> package.
> >
> > It is ready at the addresses:
> >
> > https://salsa.debian.org/krekhov/devilutionx
> > https://mentors.debian.net/package/devilutionx
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1104851
>
> A first change is required in debian/control:
> Section: games
> should be replaced with:
> Section: non-free/games
>
> I think the short version of the SustainableUse license in
> debian/copyright should be updated in some way too. Right now we have to
> go to the upstream-provided LICENSE.md and notice these sentences to know
> this is actually not a DFSG-compatible license:
> You may use or modify the software only for your own internal business
> purposes or for non-commercial or personal use.
> You may distribute the software or provide it to others only if you do so
> free of charge for non-commercial purposes.
>
> That makes the opening of the following sentence in the SustainableUse
> license summary in debian/copyright wrong:
> This package is free software; (…)
>
> And to conclude with that license, debian/copyright should include a
> Disclaimer field explaining why this package is not part of Debian
> proper (here because of the restriction to commercial us):
>
> https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#disclaimer-field
>
> ---
>
> About lintian overrides, the following is not a false positive:
> old-fsf-address-in-copyright-file
>
> Said address is included in the summary of the GPL-2 license in
> debian/copyright, that should probably be fixed. You can probably used a
> slightly tweaked version of the text you included for GPL-2+.
>
> The following override is probably not warranted either, as it is not a
> false-positive:
> package-contains-documentation-outside-usr-share-doc
>
> You can fix that one by removing the following entry from
> debian/devilutionx-data.install:
> usr/share/diasurgical/devilutionx/README.txt
> and instead include it in a new file debian/devilutionx-data.docs
>
> ---
>
> In debian/copyright, you have many similar single-file entries like this
> example:
> Files: dist/asio-src/asio/include/asio/as_tuple.hpp
> Copyright: 2003-2023 Christopher M. Kohlhoff (chris at kohlhoff dot com)
> License: BSL-1.0
>
> Files: dist/asio-src/asio/include/asio/async_result.hpp
> Copyright: 2003-2023 Christopher M. Kohlhoff (chris at kohlhoff dot com)
> License: BSL-1.0
>
> Files: dist/asio-src/asio/include/asio/awaitable.hpp
> Copyright: 2003-2023 Christopher M. Kohlhoff (chris at kohlhoff dot com)
> License: BSL-1.0
>
> This can actually be merged into a single entry, like this:
> Files:
>  dist/asio-src/asio/include/asio/as_tuple.hpp
>  dist/asio-src/asio/include/asio/async_result.hpp
>  dist/asio-src/asio/include/asio/awaitable.hpp
> Copyright: 2003-2023 Christopher M. Kohlhoff (chris at kohlhoff dot com)
> License: BSL-1.0
>
> Or, even better, if the license applies to all files in that directory
> (I did not check if this is the case for that example):
> Files: dist/asio-src/asio/include/asio/*
> Copyright: 2003-2023 Christopher M. Kohlhoff (chris at kohlhoff dot com)
> License: BSL-1.0
>
> More precise entries take priority on more global ones, so you can write
> something like this too:
> Files: dist/libzt-src/ext/ZeroTierOne/*
> Copyright: 2019 ZeroTier, Inc.
> License: Apache-2.0
>
> Files: dist/libzt-src/ext/ZeroTierOne/ext/bin/tap-windows-ndis6/*
> Copyright: 2002-2014 OpenVPN Technologies, Inc. *
> License: GPL-2
>
> Files: dist/libzt-src/ext/ZeroTierOne/ext/hiredis-0.14.1/*
> Copyright: 2010-2011 Pieter Noordhuis
> License: BSD-3-clause
>
> While it might look like a cosmetic change only, it actually makes the
> debian/copyright review much easier by strongly reducing its length.
>
> ---
>
> In debian/control, you set explicit dependencies for devilutionx on
> libsdl2-2.0-0 and libsdl2-image-2.0-0. This is not required, these are
> already automatically set from the Build-Depends list above.
>
> ---
>
> If you want this package to be team-maintained, you should replace the
> current Maintainer field with:
> Maintainer: Debian Games Team <[email protected]>
> Uploaders: Kirill Rekhov <[email protected]>
>
> Updating the Vcs-* fields would be required when the packaging
> repository is moved into the team namespace. Maybe it’s worth doing it
> for the initial upload already, and move that repository as soon as we
> have a bit of time for that? (I asked on IRC for your account to be added
> to our team)
> Vcs-Git: https://salsa.debian.org/games-team/devilutionx.git
> Vcs-Browser: https://salsa.debian.org/games-team/devilutionx
>
> ---
>
> And that’s all, please send me a ping when you’re done fixing what I
> reported, and I think this time it sould finally be ready for an initial
> upload!
>
> Take as much time as you need for that, my proposal to sponsor this
> upload is not time-limited in any way.
>

Bug#1104851: RFS: devilutionx/1.5.4+ds2-1 [ITP] -- diablo build for modern operating systems

Reply via email to