The initial kill call (actually a killall call at that point in time,
replaced with pgrep + kill later) was added more than ten years ago:

-----
commit 68cd63d040d51087e04cda1fe27c7a6d0d7c0be2
Author: Mirco Bauer <[email protected]>
Date:   Thu Jan 16 10:01:05 2014 +0100

    Hard kill stray mono processes after each test pass to make the life of 
buildd admins nicer

diff --git a/debian/rules b/debian/rules
index 48df8d9b5c..f5622f8c87 100755
--- a/debian/rules
+++ b/debian/rules
@@ -56,9 +56,10 @@ ifneq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
     MONO_SGEN_TEST = true
 else
     TIMEOUT = timeout -k 1h 1h
-    MINI_TEST = cd mono/mini && $(TIMEOUT) make check
-    MONO_BOEHM_TEST = cd mono/tests && MONO_ENV_OPTIONS=--gc=boehm $(TIMEOUT) 
make test
-    MONO_SGEN_TEST = cd mono/tests && MONO_ENV_OPTIONS=--gc=sgen $(TIMEOUT) 
make test
+    KILL_MONO = killall -9 mono
+    MINI_TEST = cd mono/mini && $(TIMEOUT) make check; $(KILL_MONO)
+    MONO_BOEHM_TEST = cd mono/tests && MONO_ENV_OPTIONS=--gc=boehm $(TIMEOUT) 
make test; $(KILL_MONO)
+    MONO_SGEN_TEST = cd mono/tests && MONO_ENV_OPTIONS=--gc=sgen $(TIMEOUT) 
make test; $(KILL_MONO)
 endif
 ifeq ($(DEB_BUILD_ARCH), powerpc)
     MONO_SGEN_TEST = true
-----

Hopefully this is no longer required, I am going to run some tests with
this call removed and see if I end up with rogue mono processes (keeping
in mind that my tests are run in sbuild, I don’t know how it deals with
such unending processes).

If I notice no such lingering processes, then the next src:mono upload
is going to ship without that pgrep+kill call, and as such should stop
killing unrelated processes.

Attachment: signature.asc
Description: PGP signature

Reply via email to