Package: bash-completion
Version: 1:2.16.0-7
Severity: minor
X-Debbugs-Cc: [email protected]

Hi,


The `is_filelist` opens a file with handle `DH_FILE`. This is never closed again, meaning it remains open. In this case, I recommend using:

```
        open (my $fd, '<', $file) || error("cannot read $file: $!");

        while (<$fd>) {
```

This would create a lexical scoped variable meaning perl will know it can clean it up at the end of the lexical scope. Explicit closing before `return` would be even better on top of this.

Best regards,
Niels

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to