Hello, On Mon 18 Aug 2025 at 08:10pm +02, Birger Schacht wrote:
> Package: git-debpush > Version: 13.12 > Severity: normal > X-Debbugs-Cc: [email protected] > > > Hi, > > not sure if that might be void when #1106071 is fixed, but when I run > git-debpush, I get a warning for pristine-tar data that does not exist. > I.e when I ran > >> git-debpush --baredebian --tag-only --upstream=upstream/1.8.3 > > in the swaylock repository > (https://salsa.debian.org/swaywm-team/swaylock, 0b9aa600) I get the > warning > >> git-debpush: check failed: pristine-tar data present for 1.8.3, but this >> will be ignored (#1106071) ('pristine-tar' check) > > But there is no pristine-tar data for 1.8.3 and no > 'swaylock_1.8.3.orig.tar.' in the output of git ls-tree -z --name-only > refs/heads/pristine-tar > > Maybe the return values in > https://salsa.debian.org/dgit-team/dgit/-/blob/main/git-debpush?ref_type=heads#L548 > should be inverted? Thanks for the report. I think the exit values are the correct way round, but they are not getting out of the { } block containing the 'git ls-tree' because it is in fact yielding the exit code for 'set -o pipefail' which will always be zero. Oh dear. I think maybe we have to make the { } block into a ( ) subshell in order to extract the exit code of 'git ls-tree'? -- Sean Whitton
signature.asc
Description: PGP signature
