control: retitle -1 git-debpush: --follow-tags passthrough option, escape hatches, policy on passthrough options control: severity -1 normal
Hello,
After IRC discussion this is what we think we will do:
- Add an escape hatch or hatches to pass arbitrary options to git-push
and git-tag ('git HERE tag HERE' and 'git HERE push HERE', so four
hatches).
+ Note in docs that passing options to git-tag is especially
dangerous.
+ Possibly also escape hatches for git-fetch.
We're not a wrapper for git-fetch in the same sense that we are for
git-tag and git-push, though.
- Add --follow-tags as a passthrough option, passed through to git-push.
- Document (in script header) and adopt policy that we generally highly
reticent to adopt new passthrough options, but will consider them if
they'll improve UX significantly for a broad enough group of users, as
opposed to requiring people to use the escape hatches.
These are some things that must be considered each time:
+ If it's a passthrough option for one of git-tag or git-push,
consider whether there is already or might be in the future a
same-named option for the other command. E.g. we've already a -u
passthrough option to git-tag but there is also a useful -u option
to git-push. We don't want to do that again.
+ Whether the name might be confusing in the context of tag2upload
(see below for an example).
+ Whether the option is likely to cause chaos in this context.
E.g. we're unlikely to add --tags.
+ Take into account the design principle that regular uploads
shouldn't require passing any options. If this is an option someone
might always want to pass (contexts of scripting excepted), see if
we can find some other way to meet the use case.
(For --follow-tags if someone might always want to pass it they can
configure push.followTags in their global git config.)
- Don't add an option for git-push's --no-verify, at least not yet.
Write it in a comment in the script why:
+ The name is not ideal and, specifically, could be confused with
an option changing something about how we make the tag.
+ We could rename it to --no-git-pre-push-hooks or something but I
(Sean) think many people will find that more confusing (and indeed
offputting/annoying/too opinionated) than just having to use an
escape hatch option in order to pass it.
+ We don't know how useful it is. So wait for bug reports about
really wanting it.
--
Sean Whitton
signature.asc
Description: PGP signature
