Control: tags -1 +upstream +fixed-upstream

On Tue, May 27, 2025 at 12:36:35PM +0200, Matthias Klose wrote:
> Package: src:libvirt-php
> Version: 0.5.8-7
> Tags: ftbfs sid forky
> User: [email protected]
> Usertags: libxml2.14
> 
> [this bug is NOT targeted to the upcoming trixie release]
> 
> http://qa-logs.debian.net/2025/05/23/libvirt-php_0.5.8-7_unstable_libxml2.log
> 
> [...]
> 
> ../../src/sockets.c: In function 'socket_read':
> ../../src/sockets.c:190:9: warning: 'read' specified size between
> 9223372036854775808 and 18446744073709551614 exceeds maximum object size
> 9223372036854775807 [-Wstringop-overflow=]
>   190 |         read(sfd, bigbuf, length) != length)
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../../src/sockets.c:165:19: note: destination object allocated here
>   165 |     unsigned char bigbuf[1048576];
>       |                   ^~~~~~
> In file included from /usr/include/unistd.h:1217,
>                  from ../../src/sockets.c:16:
> /usr/include/x86_64-linux-gnu/bits/unistd.h:26:1: note: in a call to
> function 'read' declared with attribute 'access (write_only, 2, 3)'
>    26 | read (int __fd, __fortify_clang_overload_arg0 (void *, ,__buf),
> size_t __nbytes)
>       | ^~~~
> ../../src/sockets.c: In function 'socket_read_and_save':
> ../../src/sockets.c:241:15: warning: 'read' specified size between
> 9223372036854775808 and 18446744073709551615 exceeds maximum object size
> 9223372036854775807 [-Wstringop-overflow=]
>   241 |         len = read(sfd, bigbuf, length);
>       |               ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../../src/sockets.c:210:19: note: destination object allocated here
>   210 |     unsigned char bigbuf[1048576];
>       |                   ^~~~~~
> /usr/include/x86_64-linux-gnu/bits/unistd.h:26:1: note: in a call to
> function 'read' declared with attribute 'access (write_only, 2, 3)'
>    26 | read (int __fd, __fortify_clang_overload_arg0 (void *, ,__buf),
> size_t __nbytes)
>       | ^~~~
> In file included from ../../src/libvirt-php.c:18:
> ../../src/libvirt-php.h:170:32: error: expected ';', ',' or ')' before
> 'ATTRIBUTE_UNUSED'
>   170 | int streamSink(virStreamPtr st ATTRIBUTE_UNUSED,
>       |                                ^~~~~~~~~~~~~~~~
> In file included from ../../src/libvirt-network.c:11:
> ../../src/libvirt-php.h:170:32: error: expected ';', ',' or ')' before
> 'ATTRIBUTE_UNUSED'
>   170 | int streamSink(virStreamPtr st ATTRIBUTE_UNUSED,
>       |                                ^~~~~~~~~~~~~~~~
> In file included from ../../src/libvirt-domain.c:12:
> ../../src/libvirt-php.h:170:32: error: expected ';', ',' or ')' before
> 'ATTRIBUTE_UNUSED'
>   170 | int streamSink(virStreamPtr st ATTRIBUTE_UNUSED,
>       |                                ^~~~~~~~~~~~~~~~
> In file included from ../../src/libvirt-connection.c:11:
> ../../src/libvirt-php.h:170:32: error: expected ';', ',' or ')' before
> 'ATTRIBUTE_UNUSED'
>   170 | int streamSink(virStreamPtr st ATTRIBUTE_UNUSED,
>       |                                ^~~~~~~~~~~~~~~~
> /bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.
> -I../../src -I..   -Wdate-time -D_FORTIFY_SOURCE=2
> -I/usr/include/php/20240924 -I/usr/include/php/20240924/main
> -I/usr/include/php/20240924/TSRM -I/usr/include/php/20240924/Zend
> -I/usr/include/php/20240924/ext -I/usr/include/php/20240924/ext/date/lib
> -I/usr/include/libxml2    -DCOMPILE_DL_LIBVIRT=1 -g -O2
> -Werror=implicit-function-declaration
> -ffile-prefix-map=/build/reproducible-path/libvirt-php-0.5.8=.
> -fstack-protector-strong -fstack-clash-protection -Wformat
> -Werror=format-security -fcf-protection -c -o libvirt_php_la-libvirt-node.lo
> `test -f 'libvirt-node.c' || echo '../../src/'`libvirt-node.c
> ../../src/libvirt-php.c:990:40: error: expected ';', ',' or ')' before
> 'ATTRIBUTE_UNUSED'
>   990 | static void catch_error(void *userData ATTRIBUTE_UNUSED,
>       |                                        ^~~~~~~~~~~~~~~~
> make[4]: *** [Makefile:605: libvirt_php_la-libvirt-network.lo] Error 1
> make[4]: *** Waiting for unfinished jobs....
> In file included from /usr/include/features.h:523,
>                  from /usr/include/errno.h:25,
>                  from ../../src/sockets.c:9:
> In function 'read',
>     inlined from 'socket_read' at ../../src/sockets.c:190:9:
> /usr/include/x86_64-linux-gnu/bits/unistd.h:32:10: warning: call to
> '__read_chk_warn' declared with attribute warning: read called with bigger
> length than size of the destination buffer [-Wattribute-warning]
>    32 |   return __glibc_fortify (read, __nbytes, sizeof (char),
>       |          ^~~~~~~~~~~~~~~
> make[4]: *** [Makefile:591: libvirt_php_la-libvirt-connection.lo] Error 1
> ../../src/libvirt-php.c: In function 'zm_startup_libvirt':
> ../../src/libvirt-php.c:1591:27: error: 'catch_error' undeclared (first use
> in this function); did you mean 'set_error'?
>  1591 |     virSetErrorFunc(NULL, catch_error);
>       |                           ^~~~~~~~~~~
>       |                           set_error
> ../../src/libvirt-php.c:1591:27: note: each undeclared identifier is
> reported only once for each function it appears in
> In function 'read',
>     inlined from 'socket_read_and_save' at ../../src/sockets.c:241:15:
> /usr/include/x86_64-linux-gnu/bits/unistd.h:32:10: warning: call to
> '__read_chk_warn' declared with attribute warning: read called with bigger
> length than size of the destination buffer [-Wattribute-warning]
>    32 |   return __glibc_fortify (read, __nbytes, sizeof (char),
>       |          ^~~~~~~~~~~~~~~
> ../../src/libvirt-php.c: At top level:
> ../../src/libvirt-domain.c: In function
> 'zif_libvirt_domain_get_screenshot_api':
> ../../src/libvirt-php.c:2585:32: error: expected ';', ',' or ')' before
> 'ATTRIBUTE_UNUSED'
>  2585 | int streamSink(virStreamPtr st ATTRIBUTE_UNUSED,
>       |                                ^~~~~~~~~~~~~~~~
> ../../src/libvirt-domain.c:2920:30: error: 'streamSink' undeclared (first
> use in this function); did you mean 'readlink'?
>  2920 |     if (virStreamRecvAll(st, streamSink, &fd) < 0) {
>       |                              ^~~~~~~~~~
>       |                              readlink
> ../../src/libvirt-domain.c:2920:30: note: each undeclared identifier is
> reported only once for each function it appears in
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../src -I.. -Wdate-time
> -D_FORTIFY_SOURCE=2 -I/usr/include/php/20240924
> -I/usr/include/php/20240924/main -I/usr/include/php/20240924/TSRM
> -I/usr/include/php/20240924/Zend -I/usr/include/php/20240924/ext
> -I/usr/include/php/20240924/ext/date/lib -I/usr/include/libxml2
> -DCOMPILE_DL_LIBVIRT=1 -g -O2 -Werror=implicit-function-declaration
> -ffile-prefix-map=/build/reproducible-path/libvirt-php-0.5.8=.
> -fstack-protector-strong -fstack-clash-protection -Wformat
> -Werror=format-security -fcf-protection -c ../../src/libvirt-node.c -fPIC
> -DPIC -o .libs/libvirt_php_la-libvirt-node.o
> make[4]: *** [Makefile:584: libvirt_php_la-libvirt-php.lo] Error 1
> make[4]: *** [Makefile:598: libvirt_php_la-libvirt-domain.lo] Error 1
> In file included from ../../src/libvirt-node.c:11:
> ../../src/libvirt-php.h:170:32: error: expected ';', ',' or ')' before
> 'ATTRIBUTE_UNUSED'
>   170 | int streamSink(virStreamPtr st ATTRIBUTE_UNUSED,
>       |                                ^~~~~~~~~~~~~~~~
> make[4]: *** [Makefile:612: libvirt_php_la-libvirt-node.lo] Error 1

FYI this has been addressed upstream.

https://gitlab.com/libvirt/libvirt-php/-/merge_requests/51

-- 
Andrea Bolognani <[email protected]>
Resistance is futile, you will be garbage collected.

Attachment: signature.asc
Description: PGP signature

Reply via email to