Package: git-debpush
Version: 13.11
Ian Jackson writes ("Re: [tag2upload 482] failed, smbus2 0.5.0-1"):
> Also, git-debpush ought to have spotted the discrepancy in
> tests/test_smbus2.py between HEAD and upstream - ie, the
> already-applied patch. That it didn't is a bug, which is (AFAICT) my
> fault.
I UTSL to find out why this had happened. quilt_mode is now set much
later, after git fetch. The "Quilt mode-specific checks" (i) rely on
quilt_mode being set (ii) don't have a * case to crash if the quilt
mode is unset (but I think quilt_mode is always "" for native package
frmats?). Maybe we should use `set -u`. Also, apparently, we don't
have a test case for this failed check?
I think this will have to be fixed by moving this, and the following
"git-debrebase branch format checks", much later. And possibly other
code. For example, we have "Second early sanity check" which also
depends on $quilt_mode. "Upstream tag is not ancestor of $branch".
etc.
Sean, I would be happy to try to fix this but when I was making the MR
that broke it we ended up going back and forth a whole lot about
precisely what the code structure dividers ought to say and what the
conceptual sections were. I think it might be easier if you just did
it the way you would like...
Ian.
--
Ian Jackson <[email protected]> These opinions are my own.
Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.
