Control: owner -1 ! Hi!
> Thanks for writing dep-14-convert-git-branch-names. I played around > with it a bit, and I found an issue with two repositories of my > random selection: > - - > https://salsa.debian.org/perl-team/modules/packages/libwiki-toolkit-plugin-diff-perl This yields 404 but from https://tracker.debian.org/pkg/libwiki-toolkit-plugin-diff-perl I found tps://salsa.debian.org/dom/libwiki-toolkit-plugin-diff-perl/-/tree/upstream which has last commit 17 years ago. > - - https://salsa.debian.org/perl-team/modules/packages/libmemory-usage-perl I see https://salsa.debian.org/perl-team/modules/packages/libmemory-usage-perl/-/commits/upstream has last commit 10 years ago. > In both repos, it doesn't find the upstream branch. > I notice that both repos only have 1 commit on the upstream branch > (the original import), maybe that's related? > > No patch or MR as I don't really understand the algorithm of the > find_upstream_branch() function (with parent1 and parent2); I'm just > wondering if a fallback/default name would help, i.e. "if no branch > is found, and there is a branch called 'upstream' then take it. It expects to find a merge on the upstream branch. In the case of libmemory-usage-perl/ there are zero merges in the history, as the package never updated anything from upstream. For https://salsa.debian.org/dom/libwiki-toolkit-plugin-diff-perl/-/network/upstream there are multiple merge commits, but none of them was merging from 'upstream', which actually never changed in package history. Potential fix posted at https://salsa.debian.org/debian/devscripts/-/merge_requests/532
