Control: tags -1 moreinfo

Martin-Éric Racine:
Package: debhelper
Version: 13.24.2
Severity: normal
X-Debbugs-Cc: [email protected]

In its current form, dh_installsystemd installs debian/package.unit which 
essentially follows dh_installinit logic.

This doesn't work for packages that ship multiple units, especially timers. For 
instance, src:apt ships the following units via bin:apt:

apt-daily.service
apt-daily.timer
apt-daily-upgrade.service
apt-daily-upgrade.timer

They have to be manually installed via debian/apt.install because 
dh_installsystemd cannot deal with filenames that deviate from the package.unit 
format.

A better logic would be something similar to dh_installcron:

apt.apt-daily.service
apt.apt-daily.timer
apt.apt-daily-upgrade.service
apt.apt-daily-upgrade.timer

This would enable specifying which of the binary targets should ship the files.

Basically, if there are package.unit files, ship them with package. If there 
are package.*.unit files, ship them with the binary target specified before the 
first period.

Martin-Éric

[...]

Hi Martin-Éric,

I understand were you are coming from, but I do not understand the reference to `dh_installcron` in this. As far as I can tell, `dh_installcron` finds the files with the same limitations as `dh_installsystemd`.

For what it is worth, I believe you can use `--name` with both scripts to use `<package>.<name>.<stem>`. I think the hardest part of this for `dh_installsystemd` is that is generate snippets as well, where `dh_installcron` does not. This is why `dh_installsystemd` cannot just glob all the units because you might deliberately want to call `dh_installsystemd` to have different rules for each unit.


Note it is one of the things I am trying to solve better with `debputy`, but I am not convinced the changes can be ported to `debhelper` since the snippet generation (and similar) rely on relevant tool being called multiple times.

Best regards,
Niels

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to