Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian....@packages.debian.org
Usertags: pu
X-Debbugs-Cc: d...@packages.debian.org
Control: affects -1 + src:dgit

Hello,

After Russ's security review of tag2upload, we made a small change to the tag
metadata format.  As a result, the version of git-debpush in bookworm became
useless.  This bookworm-pu fixes that problem by backporting the change.

The impact on users is more than uselessness -- if someone forgets they're on
bookworm and types 'git debpush' to upload, it will fail, but they will burn
the version number.  That is, they will need to add a new changelog stanza
with a new Debian revision in order to try again.  Some people really dislike
doing that.

I don't believe there is any possible negative impact to this update, because
a tag2upload service using the older metadata format was never deployed.

I have tested this on my bookworm laptop by debpushing src:dgit-test-dummy to
our half-deployed live service, and it worked correctly.  I also ran the
autopkgtests for the whole source package in bookworm.

As git-debpush in bookworm is useless right now, and the change is so tiny,
I've uploaded.

Thanks!

-- 
Sean Whitton
diff -Nru dgit-10.7+deb12u2/debian/changelog dgit-10.7+deb12u3/debian/changelog
--- dgit-10.7+deb12u2/debian/changelog  2023-09-03 07:49:57.000000000 +0800
+++ dgit-10.7+deb12u3/debian/changelog  2025-03-03 14:46:58.000000000 +0800
@@ -1,3 +1,9 @@
+dgit (10.7+deb12u3) bookworm; urgency=medium
+
+  * git-debpush: Add source= & version= (Closes: #1069001).
+
+ -- Sean Whitton <spwhit...@spwhitton.name>  Mon, 03 Mar 2025 14:46:58 +0800
+
 dgit (10.7+deb12u2) bookworm; urgency=medium

   * Prevent pushing older versions than is in the archive.
diff -Nru dgit-10.7+deb12u2/git-debpush dgit-10.7+deb12u3/git-debpush
--- dgit-10.7+deb12u2/git-debpush       2023-09-03 07:49:57.000000000 +0800
+++ dgit-10.7+deb12u3/git-debpush       2025-03-03 14:46:58.000000000 +0800
@@ -481,7 +481,7 @@
 tagmessage="$source release $version for $target

 [dgit distro=$distro split$quilt_mode_text]
-[dgit please-upload$upstream_info]
+[dgit please-upload source=$source version=$version$upstream_info]
 "

 git tag "${git_tag_opts[@]}" -s -m "$tagmessage" "$debian_tag" "$branch"

Attachment: signature.asc
Description: PGP signature

Reply via email to