Control: tags -1 moreinfo

Hold on, I'm told that this hunk introduces an ABI breakage:
> +--- dcmtk.orig/dcmdata/include/dcmtk/dcmdata/dcelem.h
> ++++ dcmtk/dcmdata/include/dcmtk/dcmdata/dcelem.h
> +@@ -143,6 +143,11 @@
> +      */
> +     virtual OFBool isLeaf() const { return OFTrue; }
> + 
> ++    /** check if this element can be safely casted to DcmElement
> ++     *  @return true if DcmElement, false otherwise
> ++     */
> ++    virtual OFBool isElement() const { return OFTrue; }
> ++
> +     /** check if value of this element is loaded into main memory
> +      *  @return true if value is present in memory, false if value still 
> resides in file
> +      */
> +--- dcmtk.orig/dcmdata/include/dcmtk/dcmdata/dcobject.h
> ++++ dcmtk/dcmdata/include/dcmtk/dcmdata/dcobject.h
> +@@ -1,6 +1,6 @@
> + /*
> +  *
> +- *  Copyright (C) 1994-2020, OFFIS e.V.
> ++ *  Copyright (C) 1994-2024, OFFIS e.V.
> +  *  All rights reserved.  See COPYRIGHT file for details.
> +  *
> +  *  This software and supporting documentation were developed by
> +@@ -308,6 +308,11 @@
> +      */
> +     virtual OFBool isLeaf() const = 0;
> + 
> ++    /** check if this element can be safely casted to DcmElement
> ++     *  @return true if DcmElement, false otherwise
> ++     */
> ++    virtual OFBool isElement() const { return OFFalse; }
> ++
> +     /** check if this element is nested in a sequence of items, i.e.\ not a
> +      *  top-level or stand-alone element
> +      *  @return true if this element is nested, false otherwise

I'm not sure how come this hasn't cropped up with autopkgtest of
reverse dependencies.  Anyway, I see in #1094991 that Adrian
Bunk can offer a better proposal.

Have a nice day,  :)
-- 
  .''`.  Étienne Mollier <emoll...@debian.org>
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/1, please excuse my verbosity
   `-    on air: Pattern-Seeking Animals - No Burden Left To Ca…

Attachment: signature.asc
Description: PGP signature

Reply via email to