Xiyue Deng <manp...@gmail.com> writes: > Hi Aymeric, > > Great to hear back from you! Please see my reply below. > > Aymeric Agon-Rambosson <aymeric.a...@yandex.com> writes: > >> Hi, >> >> Sorry for the late answer. >> >> I am confused. If the upstream of package pg-el changed, can we >> just not follow that new upstream and pull from it ? This is what >> I usually do when upstream changes. >> >> You are saying https://github.com/emarsden/pg-el (new) and >> https://github.com/cbbrowne/pg.el (old) are different packages, >> but we could perfectly argue that they are two different upstreams >> of the same package, with https://github.com/emarsden/pg-el >> shipping a much more recent version (0.47) than >> https://github.com/cbbrowne/pg.el (0.13+). In fact the first >> commit of https://github.com/cbbrowne/pg.el explicitly mentions >> Eric Marsden by name, and that name is listed as the author in >> both repos. The years in the copyright declaration are also >> consistent. I contend this is the same package, more than 10 years >> apart (which would explain the different API). >> >> So rather that doing all this removing and re-adding (thus having >> to clear NEW, and having to temporarily modify the dependencies of >> emacsql), we should simply update the pg-el package to follow the >> real upstream. >> >> This would require no change at all in emacsql. If I understand >> correctly, following the "real" upstream would automatically fix >> the connector in emacsql ? If that is true, then I'd argue that >> the connector is not broken, it is just expecting a reasonably >> recent version of the underlying library it is connecting to >> (albeit without mentioning it in the Package-Requires header, >> which is not nice, I agree). >> >> Tell me what you think, but I think that this bug should be >> attributed to package pg-el instead, in order to force an update >> before the freeze. >> > > I agree that both projects share the same initial work, as the first few > commits of the newer project mentions importing the 0.10 package from > 2002[1]. The reason I propose to create a new package is that I'm not > sure whether it is acceptable to evolve a source package that diverges, > as pg-el (newer one) is not a direct fork of pg.el (old one), so the > history diverges significantly. Creating a new source package is > cleaner. But if that is acceptable, I agree that this will require the > least trouble. Let me know what you think. > > Meanwhile I can try to work on emacs-pg-el with the new upstream and see > if there may be any trouble. >
This is now implemented and I created a MR[1] and assigned you as the reviewer. If this looks OK I'll merge and RFS. Let me know. Thanks! (Will also reassign this bug and revert the changes on emacsql.) [1] https://salsa.debian.org/emacsen-team/emacs-pg-el/-/merge_requests/3 > [1] > https://github.com/emarsden/pg-el/commit/348c4b430f63f6e25af637559791eb54ea7e0507 > >> Best, >> >> Aymeric >> >> Le dimanche 9 février 2025 à 22:04, Xiyue Deng <manp...@gmail.com> >> a écrit : >> >>> Xiyue Deng <manp...@gmail.com> writes: >>> >>>> Xiyue Deng <manp...@gmail.com> writes: >>>> >>>>> FYI I have implemented the dropping pg-el part in a >>>>> "drop-pg-el" branch >>>>> on Salsa[1]. The diff can be found at [2]. If this looks OK >>>>> I'll apply >>>>> this on the master branch following the git-debrebase workflow >>>>> and ask >>>>> for sponsorship. >>>>> >>>>> [1] >>>>> https://salsa.debian.org/emacsen-team/emacsql/-/tree/drop-pg-el?ref_type=heads >>>>> [2] >>>>> https://salsa.debian.org/emacsen-team/emacsql/-/compare/master...drop-pg-el >>>>> >>>>> -- >>>>> Regards, >>>>> Xiyue Deng >>>> >>>> Friendly ping. IMO this bug should be considered RC. Please >>>> help >>>> review and sponsor. TIA! >>>> >>> >>> Haven't received reply from the maintainer for a while, I took >>> the >>> liberty to merged the changes I proposed to the repository[1], >>> hoping to >>> let the fix make it to Trixie. I would like to ask for >>> sponsorship for >>> uploading the changes. >>> >>> To reiterate, the proposed steps for fixing this issue are as >>> follows: >>> >>> * Uploading of emacsql 4.1.0-2 (that I merged) which stops >>> shipping >>> emacsql-pg.el, and hence removes the build dependency on >>> emacs-pg-el. >>> >>> * Request RM of emacs-pg-el (dead upstream[2], no reverse >>> dependency, >>> etc.) >>> >>> * Package the newer pg-el[3], which is the real backend of >>> emacsql-pg.el. >>> >>> * After pg-el graduates from the NEW queue, re-ship >>> emacsql-pg.el. >>> >>> Note: emacsql uses the dgit-maint-debrebase workflow. If you'd >>> like to >>> sponsor please clone the repo and run "dgit push-source" >>> directly which >>> should do the right thing. (This is also why I didn't upload to >>> mentors >>> or file any RFS.) >>> >>> TIA! >>> >>> [1] https://salsa.debian.org/emacsen-team/emacsql >>> [2] https://github.com/cbbrowne/pg.el >>> [3] https://github.com/emarsden/pg-el > > -- > Regards, > Xiyue Deng -- Regards, Xiyue Deng
signature.asc
Description: PGP signature
