Hi Jonas, On 10/02/2025 18:07, Jonas Smedegaard wrote: > Quoting Matthieu Baerts (2025-02-10 09:55:34) >> On 09/02/2025 21:56, Jonas Smedegaard wrote: >>> Quoting Matthieu Baerts (NGI0) (2025-02-09 19:57:37) >>>> Simply fix the remaining lintian warnings from: >>>> >>>> https://udd.debian.org/lintian/?packages=iwd >>> >>> I disagree with how lintian parses copyright files. >>> >>>> Files: >>>> - */configure >>>> + configure >>> >>> My intent is to match any file named "configure" at any depth - similar >>> to the example */Makefile.in at >>> https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#files-field >> >> Should it not be "*configure" and "*Makefile.in" then? > > No, that would be too broad to also cover e.g. a file "myconfigure".
Indeed. Then maybe lintian expect two entries then when there are files in the root dir, and subdirectories (which is not the case here with iwd): configure ## only the root dir */configure ## from subdirectories (but there are none there) But well, fine not to change anything here. The ticket is closed and that's OK for me! > >> According to the same doc... >> >>> Only the wildcards * and ? apply; the former matches any number of >>> characters (including none), the latter a single character. Both >>> match slashes (/) and leading dots, unlike shell globs. The pattern >>> *.in therefore matches any file whose name ends in .in anywhere in >>> the source tree, not just at the top level. >> ... it is a bit confusing: when reading this, it sounds like >> "*/configure" means all the "configure" file from any subdirectories. It >> should then match "./configure", but maybe it doesn't work like that. >> >>>> Files: >>>> - */Makefile.in >>>> + Makefile.in >>> >>> This is *exactly* the same as the example in the official definition. >> >> Is it needed to add something to silent the lintian warnings, or should >> we just ignore them? > > In my view, silencing lintian implies that lintian is wrong specifically > which is not the case: I believe lintian is wrong generally. When I (or > you?) find the energy to file a bugreport against lintian about the > issue, it makes sense to be to silence the noise with a reference to > said bugreport - see debian/source/lintian-overrides for how I do that > for another similar long-standing issue. I see, thank you for the explanation! Then such warnings can be easily ignored! > >> Note that I'm fine with only the modification you did. I only shared >> this patch because I saw the warnings. It is OK for me to ignore them. > > ...and I am happy that you did - having fresh eyes on things is great! Great! :) Cheers, Matt
