Control: tags -1 - pending
Control: tags -1 + patch help
On Thu, 16 Jan 2025 at 12:52:04 +0000, Simon McVittie wrote:
> This looks like code that was generated by valac. Patching the C code
> that was generated by valac is not sustainable: the actual source code
> is modules/gtk3/caribou-gtk-module.vala, and if anything is changed to
> resolve this bug, it should be that source (or possibly valac).
It looks as though this particular package was compiling from the
Vala-generated C code as shipped by upstream, and not from the
ultimate source code. Deleting the C code before build, so that it
will be regenerated with a modern valac (which in particular is more
gcc-14-compatible), allows the build to succeed.
> Please could someone from the cinnamon team either remove
> [dependencies on caribou], or if caribou is still essential to Cinnamon,
> take responsibility for fixing and testing caribou?
I have pushed a change to the packaging git repo for caribou which are
sufficient to make it compile, and some janitorial changes to bring the
packaging up to a reasonably modern level for trixie. These can be kept
or reverted, whichever seems most appropriate.
However, I have not tested the resulting binaries - I don't use Cinnamon,
and I don't know how to enable the Caribou-based on-screen keyboard that
it presumably supports.
If there is still a need for Caribou to be in Debian (for example for
Cinnamon's benefit), I would like someone who knows how to test it to
do so, and either upload, or reply with the git sha1 of the commit that
they successfully tested (possibly in the form of a merge request, if
further changes turn out to be needed).
I do not intend to upload this package myself unless there is a positive
testing report, and I do not intend to work on it further.
Thanks,
smcv
