Control: tags -1 patch
Niels Thykier writes ("Bug#1092929: dgit: building packages using the debputy
Build-Driver"):
> I think it is this code
> (https://salsa.debian.org/dgit-team/dgit/-/blob/master/dgit#L6613)
The fake "package tree" made by that code is never built. Its rules
file is never run and it is never fed to build tools like pbuilder or
sbuild.
It _is_ fed to dpkg-source. This "source package" is repacked and
extracted; patches are applied, dpkg-source --commit is run, etc.
Perhaps at some point in the past, dpkg-source broke if d/rules didn't
exist. (Maybe it tried to chmod it +x.)
Certainly, though, I think it is sound to move d/rules to the list of
files included only if they're in the original. This won't break any
existing packages. The worst possible outcome is that something else
breaks.
Thanks for the explanations.
Ian.
(Tagging this patch because this
> Note that @files is initialized to unconditionally include
> `debian/rules`. If that name was moved to the `foreach` below, then it
> would be filtered out when it does not exist. This list of files is
> later passed to tar, which will expect them all to exist.
is an unambiguous description of the proposed change.)
--
Ian Jackson <ijack...@chiark.greenend.org.uk> These opinions are my own.
Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.
