Bug#1089385: memstat: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 20:43:29 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: memstat
Version: 1.1+nmu1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
memstat failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

Hi

Please see attached as a patch.



Best regards,
Niels


diff -Nru memstat-1.1+nmu1/debian/changelog memstat-1.1+nmu2/debian/changelog
--- memstat-1.1+nmu1/debian/changelog   2024-02-18 16:13:24.000000000 +0100
+++ memstat-1.1+nmu2/debian/changelog   2024-12-31 15:39:49.000000000 +0100
@@ -1,3 +1,11 @@
+memstat (1.1+nmu2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+    (Closes: #1089385)
+
+ -- Niels Thykier <ni...@thykier.net>  Tue, 31 Dec 2024 14:39:49 +0000
+
 memstat (1.1+nmu1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru memstat-1.1+nmu1/debian/control memstat-1.1+nmu2/debian/control
--- memstat-1.1+nmu1/debian/control     2018-02-09 22:47:32.000000000 +0100
+++ memstat-1.1+nmu2/debian/control     2024-12-31 15:39:18.000000000 +0100
@@ -2,6 +2,7 @@
 Section: admin
 Priority: optional
 Maintainer: Michael Meskes <mes...@debian.org>
+Rules-Requires-Root: no
 Standards-Version: 4.1.3
 Build-Depends: debhelper (>= 11)
 
diff -Nru memstat-1.1+nmu1/Makefile memstat-1.1+nmu2/Makefile
--- memstat-1.1+nmu1/Makefile   2018-02-09 22:45:26.000000000 +0100
+++ memstat-1.1+nmu2/Makefile   2024-12-31 15:38:49.000000000 +0100
@@ -8,9 +8,9 @@
 exec_prefix = $(prefix)/usr
 
 INSTALL = install
-INSTALL_PROGRAM = $(INSTALL) -p -s -o root -g root  -m  755
-INSTALL_FILE    = $(INSTALL) -p    -o root -g root  -m  644
-INSTALL_DIR     = $(INSTALL) -p -d -o root -g root  -m  755
+INSTALL_PROGRAM = $(INSTALL) -p -s -m  755
+INSTALL_FILE    = $(INSTALL) -p    -m  644
+INSTALL_DIR     = $(INSTALL) -p -d -m  755
 
 memstat: memstat.c
 

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature