Bug#1089358: libcompface: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 20:30:57 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: libcompface
Version: 1:1.5.2-6
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
libcompface failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

Hi


Please see attached as a patch.



Best regards,
Niels



diff -Nru libcompface-1.5.2/debian/changelog libcompface-1.5.2/debian/changelog
--- libcompface-1.5.2/debian/changelog  2024-08-15 09:40:30.000000000 +0200
+++ libcompface-1.5.2/debian/changelog  2024-12-31 13:19:58.000000000 +0100
@@ -1,3 +1,11 @@
+libcompface (1:1.5.2-6.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+    (Closes: #1089358)
+
+ -- Niels Thykier <ni...@thykier.net>  Tue, 31 Dec 2024 12:19:58 +0000
+
 libcompface (1:1.5.2-6) unstable; urgency=high
 
   [ Ricardo Mones <mo...@debian.org> ]
diff -Nru libcompface-1.5.2/debian/rules libcompface-1.5.2/debian/rules
--- libcompface-1.5.2/debian/rules      2024-08-15 09:14:28.000000000 +0200
+++ libcompface-1.5.2/debian/rules      2024-12-31 13:19:33.000000000 +0100
@@ -100,13 +100,14 @@
        -dh_clean
 
 
-binary-indep:  checkroot build
+binary-indep:  build
        $(checkdir)
 # There are no architecture-independent files to be uploaded
 # generated by this package.  If there were any they would be
 # made here.
 
-binary-arch:   checkroot build binary-common binary-libc6
+binary-arch:   build binary-common binary-libc6
+       $(checkdir)
        @echo '### Installing architecture dependent files...'
 #make install DESTDIR=`pwd`/debian/tmp
 
@@ -226,8 +227,5 @@
 
 binary:                binary-indep binary-arch
 
-checkroot:
-       $(checkdir)
-       test root = "`whoami`"
 
-.PHONY: binary binary-arch binary-indep clean checkroot build-arch build-indep
+.PHONY: binary binary-arch binary-indep clean build-arch build-indep

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature