I have patched out use of python-unshare from python-netfilterqueue, it
was only used during self-tests but those did not work anyway.

https://salsa.debian.org/python-team/packages/python-netfilterqueue/-/commit/22a94f3ba90112ea8aa474ba2523f6c81ca1d333
https://salsa.debian.org/python-team/packages/python-netfilterqueue/-/pipelines/787900

I opened an upstream bug report to ask them to consider another
approach:

https://github.com/oremanj/python-netfilterqueue/issues/15#issuecomment-2564282968

It seems their code is here:

https://github.com/oremanj/python-netfilterqueue/blob/master/tests/test_basic.py
https://github.com/oremanj/python-netfilterqueue/blob/master/tests/conftest.py

If you (or anyone on debian-python that I'm cc'ing now) can propose a
patch for upstream, maybe that will convince them to avoid the
python-unshare dependency and we'll have better self-tests as a result.

Note that there appears to be two python-unshare: one on PyPI and
another one here: https://github.com/NightTsarina/python-unshare/

/Simon

Simon Josefsson <si...@josefsson.org> writes:

> Thank you - I agree and hope to convince upstream PQconnect to pick
> build dependencies in a better way. This was a bit further down the
> dependency stack, but hopefully they can help anyway. They brought up
> a valid concern: prefer not to depend on things not on PyPI and I
> agree (of course, within reason).  It seems unshare is there:
> https://pypi.org/project/unshare/
>
> /Simon
>
>> 28 dec. 2024 kl. 08:08 skrev Helmut Grohne <hel...@subdivi.de>:
>> 
>> Control: tags -1 + moreinfo
>> 
>> Hi Simon,
>> 
>>> On Fri, Dec 27, 2024 at 08:24:28PM +0100, Simon Josefsson wrote:
>>> Package: wnpp
>>> Severity: wishlist
>>> Owner: Simon Josefsson <si...@josefsson.org>
>>> X-Debbugs-Cc: debian-de...@lists.debian.org, debian-pyt...@lists.debian.org
>>> 
>>> * Package name    : python-unshare
>>>  Version         : 0.22
>>>  Upstream Author : Shubham Sharma <shubhamsharma1...@gmail.com>
>>> * URL             : https://github.com/shubham1172/unshare
>>> * License         : GPL-3
>>>  Programming Lang: Python
>>>  Description     : extension for C unshare() call
>>> 
>>> Python extension for C's unshare call, see unshare(2).
>>> 
>>> https://salsa.debian.org/python-team/packages/python-unshare/
>> 
>> I recommend not adding this to Debian. This Python extension wraps a
>> single syscall. You can achieve a similar effect using ctypes.
>> 
>>    import ctypes
>>    unshare = ctypes.CDLL(None, use_errno=True)["unshare"]
>>    unshare(flags)
>> 
>> The functionality being added here is useful, but in my opinion it does
>> not reach the bar of being sufficiently useful to warrant the cost of
>> carrying it in Debian yet. Bear in mind that every package being added
>> bears a permanent cost to Debian.
>> 
>> Please allow me to suggest an alternative.
>> https://git.subdivi.de/~helmut/python-linuxnamespaces.git/
>> Disclaimer: I am the author of the alternative.
>> 
>> I did not dare to propose adding this to Debian yet, because I consider
>> it work in progress, but even at this time, it does so much more than
>> the module you propose that it probably is worth looking into. It is not
>> API compatible, because it uses the enum module instead of numeric
>> constants. It also includes a pile of examples for more elaborate
>> container construction.
>> 
>> Helmut
>> 

Attachment: signature.asc
Description: PGP signature

Reply via email to