Control: tags 1075218 patch Dear libx86 maintainer,
I have developed a fix for this failure to build from source with gcc-14 for the forthcoming trixie release and would be grateful if you would consider merging it, please! The merge request is available at: <https://salsa.debian.org/kkamagui/libx86/-/merge_requests/1> This patch fixes the incorrect return type declared for a function used as a function pointer by correcting a type assignment for 64-bit targets. On Wed, Jul 03, 2024 at 12:34:43PM +0000, Matthias Klose wrote: [abridged quoting] > [This bug is targeted to the upcoming trixie release] > The package fails to build in a test rebuild on at least amd64 with > gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The > severity of this report will be raised before the trixie release. Fixed by this patch: > thunk.c:150:17: error: initialization of ‘x86emuu32 (*)(X86EMU_pioAddr)’ {aka > ‘unsigned int (*)(short unsigned int)’} from incompatible pointer type ‘long > unsigned int (*)(short unsigned int)’ [-Wincompatible-pointer-types] > thunk.c:153:17: error: initialization of ‘void (*)(X86EMU_pioAddr, > x86emuu32)’ {aka ‘void (*)(short unsigned int, unsigned int)’} from > incompatible pointer type ‘void (*)(short unsigned int, long unsigned int)’ > [-Wincompatible-pointer-types] Not fixed in this patch: > x86emu/debug.c:220:13: warning: variable ‘current’ set but not used > [-Wunused-but-set-variable] > x86emu/debug.c:247:11: warning: variable ‘p’ set but not used > [-Wunused-but-set-variable] > x86-common.c:193:17: warning: cast to pointer from integer of different size > [-Wint-to-pointer-cast] > x86-common.c:200:17: warning: cast to pointer from integer of different size > [-Wint-to-pointer-cast] > thunk.c:168:18: warning: cast from pointer to integer of different size > [-Wpointer-to-int-cast] > thunk.c:200:26: warning: cast from pointer to integer of different size > [-Wpointer-to-int-cast] > x86emu/prim_ops.c:1836:5: warning: this ‘else’ clause does not guard... > [-Wmisleading-indentation] > x86emu/prim_ops.c:1861:5: warning: this ‘else’ clause does not guard... > [-Wmisleading-indentation] I hope this helps! I notice that as well as the declared packaging repository in your namespace on salsa, there is also one under the debian namespace. This can be confusing for contributors like me when seeking to raise a merge request. Would it be worth considering getting yourself added with suitable rights to be able to use the debian/libx86 repo as the authoritative one? Thanks, Andrew
signature.asc
Description: PGP signature
