[Christian Meyer]
> Sorry, I don't know, how to apply your patch correctly and there has
> been errors:
Ah, sorry about that. It was related to my git repo, probably not
identical to the version you had.
> Anyway:
> I applied your changes by hand and I can confirm both problems are
> gone:
Good.
I've just uploaded a improved isenkram-autoinstall-firmware enforcing
the use of LC_ALL=C and quotes around firmware file names. I did not
include the change below, as I do not quite understand what wildcard
firmware file entries are supposed to mean in kernel modules, and
decided to delay its inclusion until I do.
diff --git a/isenkram-autoinstall-firmware b/isenkram-autoinstall-firmware
index dd9df64..8bcd156 100755
--- a/isenkram-autoinstall-firmware
+++ b/isenkram-autoinstall-firmware
@@ -58,11 +58,14 @@ appstreamlookup() {
awk '/Package:/ { print $2}'
}
-# Find firmware files requested by loaded kernel drivers.
-for fwfile in $(for module in $(awk '{print $1}' /proc/modules) ; do modinfo
$module 2>/dev/null |awk '/^firmware:/ {print $2}'; done | LC_ALL=C sort -u); do
- if [ ! -e "/lib/firmware/$fwfile" ] ; then
- fwfiles="${fwfiles:+$fwfiles }$fwfile"
- fi
+# Find firmware files requested by loaded kernel drivers. Some entries use
+# wildcard strings.
+for fwwildcard in $(for module in $(awk '{print $1}' /proc/modules) ; do
modinfo $module 2>/dev/null |awk '/^firmware:/ {print $2}'; done | LC_ALL=C
sort -u); do
+ for fwfile in $fwwildcard; do
+ if [ ! -e "/lib/firmware/$fwfile" ] ; then
+ fwfiles="${fwfiles:+$fwfiles }$fwfile"
+ fi
+ done
done
# Also look in dmesg for requested firmware for modules that refuse to
I do expect the uploaded change to fix the error messages you saw. The
proposal of a rpi related package for your x86 machine need to be fixed
outside isenkram, as mentioned earlier.
--
Happy hacking
Petter Reinholdtsen
