Control: tags -1 +confirmed Jorg,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Information only Running lintian... N: W: libunistring source: newer-standards-version 4.7.0.1 (current is 4.7.0) N: N: The source package refers to a Standards-Version which is newer than the N: highest one Lintian is programmed to check. N: N: If the source package is correct, please upgrade Lintian to the newest N: version. N: N: Visibility: warning N: Show-Always: no N: Check: fields/standards-version N: N: I: libunistring5: spelling-error-in-binary Teh The [usr/lib/x86_64-linux- gnu/libunistring.so.5.2.0] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling N: N: P: libunistring source: license-problem-gfdl-non-official-text invariant part is: with no invariant sections, with no front-cover text, and with no back- cover texts [doc/libunistring.texi] N: N: The given source file is licensed under GFDL, but using a non-official N: text for the "no invariant sections" part. N: N: Please ask upstream to always use (case insensitive): with no Invariant N: Sections, no Front-Cover Texts, and no Back-Cover Texts. N: N: Visibility: pedantic N: Show-Always: no N: Check: cruft N: N: P: libunistring source: license-problem-gfdl-non-official-text invariant part is: with no invariant sections, with no front-cover text, and with no back- cover texts [doc/libunistring_20.html] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/iconv_open-aix.h] N: N: The following file is autogenerated by gperf N: N: They are usually provided for the convenience of users. These files N: usually just take up space in the tarball. N: N: Check if upstream also provides source-only tarballs that you can use as N: the upstream distribution instead. If not, you may want to ask upstream to N: provide source-only tarballs. N: N: Visibility: pedantic N: Show-Always: no N: Check: cruft N: N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/iconv_open-hpux.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/iconv_open-irix.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/iconv_open-osf.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/iconv_open-solaris.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/iconv_open-zos.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/unicase/locale-languages.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/unicase/special-casing-table.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/unictype/bidi_byname.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/unictype/categ_byname.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/unictype/combiningclass_byname.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/unictype/incb_byname.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/unictype/joininggroup_byname.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/unictype/joiningtype_byname.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/unictype/pr_byname.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/unictype/scripts_byname.h] N: P: libunistring source: source-contains-autogenerated-gperf-data [lib/uninorm/composition-table.h] I: Lintian run was successful. 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: Good Summary... Great work, looks good to me. I believe libunistring is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Donations... Buy Me A Coffee: https://buymeacoffee.com/kathenasorg -- Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
