Control: tags -1 patch

Hi,

On Sun, 18 Aug 2024 18:04:41 +0200 Gilles Filippini <p...@debian.org> wrote:
> Source: csound-plugins
> Version: 1.0.2~dfsg1-3
> Severity: important
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Hi,
>
> The csound-plugins package fails to build from source in a test rebuild
> against hdf5 1.14 currently in experimental:
>
> cd "/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/hdf5" && /usr/bin/cc -DHAVE_SOCKETS -DHDF5_VERSION_MAJOR=1 -DHDF5_VERSION_MINOR=14 -DHDF5_VERSION_PATCH=4-3 -DLINUX -DNO_FLTK_THREADS -DPIPES -D_GNU_SOURCE -Dhdf5ops_EXP > ORTS -I/usr/include/hdf5/serial -I/usr/include/csound -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-s > ecurity -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -g -ffast-math -mfpmath=sse -msse2 -fomit-frame-pointer -fvisibility=hidden -std=gnu99 -DHAVE_PTHREAD -fPIC -MD -MT hdf5/CMakeFiles/hdf5ops.dir/HDF5IO.c.o > - -MF CMakeFiles/hdf5ops.dir/HDF5IO.c.o.d -o CMakeFiles/hdf5ops.dir/HDF5IO.c.o -c "/<<PKGBUILDDIR>>/hdf5/HDF5IO.c"
> In file included from /usr/include/csound/csoundCore.h:35,
> from /usr/include/csound/csdl.h:111,
> from /<<PKGBUILDDIR>>/hdf5/HDF5IO.h:20,
> from /<<PKGBUILDDIR>>/hdf5/HDF5IO.c:20:
> /<<PKGBUILDDIR>>/hdf5/HDF5IO.c: In function ‘HDF5IO_readStringAttribute’:
> /<<PKGBUILDDIR>>/hdf5/HDF5IO.c:233:39: error: passing argument 2 of ‘H5Oget_info1’ from incompatible pointer type [-Wincompatible-pointer-types]
> 233 | HDF5ERROR(H5Oget_info1(dataSetID, &oinfo));
> | ^~~~~~
> | |
> | H5O_info2_t *
> /usr/include/csound/sysdep.h:345:45: note: in definition of macro ‘UNLIKELY’
> 345 | # define UNLIKELY(x) __builtin_expect(!!(x),0)
> | ^
> /<<PKGBUILDDIR>>/hdf5/HDF5IO.c:233:5: note: in expansion of macro ‘HDF5ERROR’
> 233 | HDF5ERROR(H5Oget_info1(dataSetID, &oinfo));
> | ^~~~~~~~~
> In file included from /usr/include/hdf5/serial/H5Apublic.h:21,
> from /usr/include/hdf5/serial/hdf5.h:22,
> from /<<PKGBUILDDIR>>/hdf5/HDF5IO.h:21:
> /usr/include/hdf5/serial/H5Opublic.h:1854:55: note: expected ‘H5O_info1_t *’ but argument is of type ‘H5O_info2_t *’
> 1854 | H5_DLL herr_t H5Oget_info1(hid_t loc_id, H5O_info1_t *oinfo);
> | ~~~~~~~~~~~~~^~~~~
> make[3]: *** [hdf5/CMakeFiles/hdf5ops.dir/build.make:79: hdf5/CMakeFiles/hdf5ops.dir/HDF5IO.c.o] Error 1
>
>
> Adding -DH5_USE_110_API to CPPFLAGS fixes the issue.

Indeed, altering the debian/rules file to add

# Build with HDF5 1.14.x
export DEB_CPPFLAGS_MAINT_APPEND = -DH5_USE_110_API

just before the "%:" line fixes the build.

>
> Best,
> _g.
>

Best,

--
Pierre

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to