Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian....@packages.debian.org
Usertags: pu
X-Debbugs-Cc: s...@packages.debian.org, sanv...@debian.org
Control: affects -1 + src:sumo

[ Reason ]
This upload fixes FTBFS Bug #1082135, a case of "unintended parallelism".
A bashism &> made doxygen to work in the background from dh_auto_build.
By the time dh_installdocs works, doxygen was still writing things
in the directory on which dh_installdocs was supposed to act.

[ Impact ]
Anybody trying to build the package from source may potentially
get the build failure. In some systems it has been observed
a failure rate of 100%.

[ Tests ]
I've tested that the package builds ok in a machine where the
build used to fail.

[ Risks ]
Very low. The fix is a one-liner.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
Fix bashism in CMakeLists.txt.

[ Other info ]
The debdiff is attached. I'm uploading the package now, but I will
wait for confirmation before pushing to salsa.
diff -Nru sumo-1.15.0+dfsg/debian/changelog sumo-1.15.0+dfsg/debian/changelog
--- sumo-1.15.0+dfsg/debian/changelog   2022-12-17 09:20:08.000000000 +0100
+++ sumo-1.15.0+dfsg/debian/changelog   2024-10-28 16:44:00.000000000 +0100
@@ -1,3 +1,10 @@
+sumo (1.15.0+dfsg-1+deb12u1) bookworm; urgency=medium
+
+  * Team upload.
+  * Remove bashism from CMakeLists.txt. Closes: #1082135.
+
+ -- Santiago Vila <sanv...@debian.org>  Mon, 28 Oct 2024 16:44:00 +0100
+
 sumo (1.15.0+dfsg-1) unstable; urgency=medium
 
   * Team upload.
diff -Nru sumo-1.15.0+dfsg/debian/patches/remove-bashism-from-cmakelists.patch 
sumo-1.15.0+dfsg/debian/patches/remove-bashism-from-cmakelists.patch
--- sumo-1.15.0+dfsg/debian/patches/remove-bashism-from-cmakelists.patch        
1970-01-01 01:00:00.000000000 +0100
+++ sumo-1.15.0+dfsg/debian/patches/remove-bashism-from-cmakelists.patch        
2024-10-28 16:42:21.000000000 +0100
@@ -0,0 +1,16 @@
+Description: Redirect stdout and stderr in a POSIX-compatible way
+Author: Santiago Vila <sanv...@debian.org>
+Bug-Debian: https://bugs.debian.org/1082135
+Last-Update: 2024-10-28
+
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -566,7 +566,7 @@
+ add_custom_target(doxygen
+     COMMAND rm -rf docs/doxygen
+     COMMAND mkdir docs/doxygen
+-    COMMAND doxygen sumo.doxyconf &> doxygen.log
++    COMMAND doxygen sumo.doxyconf > doxygen.log 2>&1
+     WORKING_DIRECTORY ${CMAKE_SOURCE_DIR})
+ set_property(TARGET doxygen PROPERTY EXCLUDE_FROM_DEFAULT_BUILD TRUE)
+ set_property(TARGET doxygen PROPERTY FOLDER "doc")
diff -Nru sumo-1.15.0+dfsg/debian/patches/series 
sumo-1.15.0+dfsg/debian/patches/series
--- sumo-1.15.0+dfsg/debian/patches/series      2022-12-15 08:51:00.000000000 
+0100
+++ sumo-1.15.0+dfsg/debian/patches/series      2024-10-28 16:42:21.000000000 
+0100
@@ -1,3 +1,4 @@
 60_fix_tests.patch
 setuptools.patch
 python3.patch
+remove-bashism-from-cmakelists.patch

Reply via email to