* Jeroen Ploemen <j...@debian.org> [2024-10-09 12:37]: > your package is in really good shape overall. Please find my review > and suggestions at the bottom of this mail.
Hi Jeroen, thanks for your review. > > About bugs #885467, #937175 and #773201: they were closed when the > > package was removed, should I re-open them before the upload, or is > > it handled at upload time? > See developer reference [0]. I have read it already, my question was more about timing, should I open them before the upload? If I do so, there will be a (hopefully) small time window when the bug is open, but the package is not back in debian yet. > [...] > Finally, the very minor things that came up during review...: > * control: > + is the python3-usb build-dependency used for anything other than > running tests? If not, it could be marked "<!nocheck>". This is needed for tests and/or doc. I was thinking that dh_python needed it to auto detect the dependency, but it seems that is not the case. Will do the change. > + is Pere still involved with this package? Yes, I have got the confirmation he is still interested in it. > [...] > * Enable the CI on salsa [1]. This is a very powerful quality control > tool for maintainers and sponsors alike. Done already on my own fork, will request it for team repo. Thanks for the review, I will do the changes and prepare a new upload. Nicolas.
signature.asc
Description: PGP signature
