On Thu, Jun 08, 2006 at 07:10:35PM +0200, Davide G. M. Salvetti wrote:
> tags 372146 + confirmed pending
> thanks
> >>>>> JP == Justin Pryzby [2006-6-8]
>
> JP> Package: preview-latex-style
> JP> Version: 11.82-1
> JP> Tags: patch
>
> JP> The prerm failed-upgrade case is called when upgrade fails, as a
> JP> second chance at the same thing, not as a rollback request.
>
> You are right, thanks.
>
> JP> The other maintscripts need to have their *) messages fixed too.
>
> JP> - (failed-upgrade)
> JP> - test -x /usr/sbin/install-docs && install-docs --install
> /usr/share/doc-base/preview-latex-style
> JP> - ;;
> JP> - (*) echo >&2 "${0##*/}/auctex:" \
> JP> - "Unknown argument: \"${1}\"."
> JP> + *)
> JP> + echo "$0: Unknown argument: \"${1}\"." >&2;
> JP> + exit 1;
> JP> ;;
> JP> esac
>
> Beside "exit 1", which I understand and agree with, are you also
> suggesting to use $0 rather than ${0##*/}/auctex? If so, why?
Yes; because this is not auctex (right?).
> Out of curiosity: how do you spotted these bugs?
I read a huge number of maintainer scripts, while writing a "How To
Write Maint Scripts" document. :)
Justin
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
