Control: tags -1 +moreinfo

Thomas,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Issues

W: luit source: build-depends-on-obsolete-package Build-Depends: pkg-config
=> pkgconf
N: 
N:   The package build-depends on a package that has been superseded. If the
N:   superseded package is part of an ORed group, it should not be the first
N:   package in the group.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: fields/package-relations
N: 
N:
I: luit source: out-of-date-standards-version 4.6.1.0 (released 2022-05-11)
(current is 4.7.0)
N: 
N:   The source package refers to a Standards-Version older than the one that
N:   was current at the time the package was created (according to the
N:   timestamp of the latest debian/changelog entry). Please consider
updating
N:   the package to current Policy and setting this control field
N:   appropriately.
N:   
N:   If the package is already compliant with the current standards, you
don't
N:   have to re-upload the package just to adjust the Standards-Version
control
N:   field. However, please remember to update this field next time you
upload
N:   the package.
N:   
N:   See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N:   debian-policy package for a summary of changes in newer versions of
N:   Policy.
N: 
N:   Please refer to
N:   https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/standards-version
N: 
N:
I: luit source: unused-override no-debian-changes  [debian/source/lintian-
overrides:2]
N: 
N:   Your package specifies the named override but there were no tags that
N:   could have been silenced by it.
N:   
N:   Maybe you fixed an underlying condition but forgot to remove the
override.
N:   It is also possible that the Lintian maintainers fixed a false positive.
N:   
N:   If the override is now unused, please remove it.
N:   
N:   This tag is similar to mismatched-override except there a tag could have
N:   been silenced if the context had matched.
N:   
N:   Sometimes, overrides end up not being used because a tag appears only on
N:   some architectures. In that case, overrides can be equipped with an
N:   architecture qualifier.
N: 
N:   Please refer to Architecture specific overrides (Section 2.4.3) in the
N:   Lintian User's Manual for details.
N: 
N:   Visibility: info
N:   Show-Always: yes
N:   Check: lintian
N: 
N: 0 hints overridden; 1 unused override

3. Licenses [4]: Issues, with false positives possible

philwyett@ks-tarkin:~/Development/builder/debian/mentoring/luit$ lrc
en: Versions: recon 1.18  check 3.3.9-1

Parsing Source Tree  ....
Reading copyright    ....
  Missing Files Paragraph for debian/
Running licensecheck ....

d/copyright      | licensecheck

X11              | Expat             charset.c
X11              | Expat             charset.h
X11              | Expat             fontenc.c
X11              | Expat             iso2022.c
X11              | Expat             iso2022.h
X11              | Expat             luit.c
X11              | Expat             luitconv.c
X11              | Expat             luitconv.h
X11              | Expat             luit.h
X11              | Expat             luit.log.html
X11              | Expat             luit.man
X11              | Expat             minstall.sh
X11              | Expat             other.c
X11              | Expat             other.h
X11              | Expat             package/luit.spec
X11              | Expat             parser.c
X11              | Expat             parser.h
X11              | Expat             plink.sh
X11              | Expat             sys.c
X11              | Expat             sys.h
X11              | Expat             trace.c
X11              | Expat             trace.h

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Summary...

I believe luit is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the rasied issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Threads: https://www.threads.net/@kathenasorg

--






Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to